Skip to content

Update the ClawBench benchmark pin - #172

Merged
rgarcia merged 1 commit into
mainfrom
hypeship/update-clawbench-pin
Sep 1, 2026
Merged

Update the ClawBench benchmark pin#172
rgarcia merged 1 commit into
mainfrom
hypeship/update-clawbench-pin

Conversation

@rgarcia

@rgarcia rgarcia commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move the benchmark from the pre-upstream Harbor branch to the cleaned Kernel control-arm commit rebased on ClawBench v0.10.0
  • keep the workflow checkout, runtime source assertion, local default, and documentation on one immutable SHA
  • add regression assertions for the synchronized pin

The repository remains kernel/ClawBench until the remaining Kernel-backed Harbor control arm is accepted upstream. The generic Harbor correctness changes are already upstream.

Validation

  • bun test — 263 tests
  • bunx tsc --noEmit --incremental false
  • production build with required placeholder configuration
  • Actionlint
  • Zizmor
  • bash -n benchmarks/harbor/clawbench/run.sh
  • git diff --check

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mcp Ready Ready Preview Aug 31, 2026 7:39pm

@bmsaadat bmsaadat left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with one non-blocking ask and a few optional notes.

Verified the pin itself checks out: c7feaa2 is the 4 control-arm commits rebased onto the v0.10.0 release merge, the correctness changes really are upstream (ClawBench #324, inside v0.10.0), and a full tree diff between the two pins shows everything on the benchmark path is byte-identical (harbor_adapter.py, providers.py, task.py, the whole runtime/ tree, all task assets). The lenient/strict reward reporting made it upstream, so results.ts is unaffected, and the --clawbench-sha provenance chain stamps the new pin into Braintrust correctly. All 6 SHA occurrences agree and no stale 45a71c4 references remain.

The one ask: nothing has actually run against the new pin. The validation list is static-only, and a /benchmark comment can't cover it either, since comment-triggered runs execute main's workflow file, which still carries the old SHA (the one run on this PR resolved and skipped). A single-task workflow_dispatch launched from this branch with pr_number=172 would put one live run on the new pin before the Monday cron does, and would match the live-validation bar #162/#171 set. Fine to do right after merge instead. The only residual risk is host-side: the adapter step now resolves deps from the new top-level uv.lock.

Optional:

  • The pin is only reachable via hypeship/harbor-kernel-control (head of upstream PR TIGER-AI-Lab/ClawBench#330). If upstream review forces a rebase, the SHA goes unreachable, and 45a71c4 has already rotted exactly this way (head of no branch, contained by none, repo has no tags). A lightweight tag in kernel/ClawBench on the pinned commit would be cheap insurance until #330 lands and we can repin to upstream.
  • The two new assertions hardcode the SHA a 5th and 6th time, and the README short SHA is the one copy with no guard. Deriving the ref once from run.sh (/CLAWBENCH_REF:-([0-9a-f]{40})/) and asserting the workflow contains it twice plus the README contains its 7-char prefix would need zero test edits on future bumps and fail with a pin-drift-shaped message.
  • toHaveLength(2) locks in the workflow's intra-file duplication. The job already has an env: block single-sourcing every other pin; CLAWBENCH_REF could live there once, referenced from the checkout's with: ref:.
  • Pre-existing, but this bump re-exposes it: the README says "a checkout containing pinned commit c7feaa2" without naming the branch, and links the upstream repo where the commit doesn't exist. A fresh clone on main fails run.sh's is-ancestor check with a misleading message. One clause naming the branch would save the next person a round-trip.

@rgarcia
rgarcia merged commit c4d6945 into main Sep 1, 2026
10 checks passed
@rgarcia
rgarcia deleted the hypeship/update-clawbench-pin branch September 1, 2026 01:59
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

ClawBench · PR #172 (bc58b95) vs merge base (7454ab2)

Arm Configuration Lenient Strict Intercepted Infra Ungraded Kernel MCP valid Median calls Median duration Cost
candidate codex@0.120.0 · gpt-5.6-luna · config 14a94e93 1/1 1/1 1/1 0 0 1/1 21 330s $0.0230
baseline codex@0.120.0 · gpt-5.6-luna · config 14a94e93 0/1 0/1 1/1 0 0 1/1 10 230s $0.0095

Candidate minus baseline: +1 lenient, +1 strict, +0 intercepted.

Open the Braintrust experiment

Open the GitHub Actions run

Lenient reward is the primary ClawBench score. Infrastructure failures remain in the intended-task denominator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants