From 20a315eda8acd8d4146c1aef8888410a15fcc1e6 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Wed, 22 Jul 2026 12:50:17 +0200 Subject: [PATCH] =?UTF-8?q?Revert=20"fix(cli):=20don't=20crash=20the=20res?= =?UTF-8?q?ponse=20when=20navigating=20closes=20the=20last=20ta=E2=80=A6"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 1fbd702e7250163feb3a4069a1b6eb0a2cf81189. --- packages/playwright-core/src/tools/backend/response.ts | 3 +-- tests/mcp/cli-navigation.spec.ts | 7 ------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/playwright-core/src/tools/backend/response.ts b/packages/playwright-core/src/tools/backend/response.ts index d28de344964bf..5a35236996240 100644 --- a/packages/playwright-core/src/tools/backend/response.ts +++ b/packages/playwright-core/src/tools/backend/response.ts @@ -275,8 +275,7 @@ export class Response { if (this._includeSnapshot !== 'none' || tabHeaders.some(header => header.changed)) { if (tabHeaders.length !== 1) addSection('Open tabs', renderTabsMarkdown(tabHeaders)); - if (tabHeaders.length) - addSection('Page', renderTabMarkdown(tabHeaders.find(h => h.current) ?? tabHeaders[0])); + addSection('Page', renderTabMarkdown(tabHeaders.find(h => h.current) ?? tabHeaders[0])); } // Handle modal states. diff --git a/tests/mcp/cli-navigation.spec.ts b/tests/mcp/cli-navigation.spec.ts index 3d07790288a86..74f606fadf051 100644 --- a/tests/mcp/cli-navigation.spec.ts +++ b/tests/mcp/cli-navigation.spec.ts @@ -52,10 +52,3 @@ test('run-code', async ({ cli, server }) => { const { output } = await cli('run-code', '() => page.title()'); expect(output).toContain('"Title"'); }); - -test('goto chrome:// page that closes the tab does not crash the response', async ({ cli, server, mcpBrowser }) => { - test.skip(mcpBrowser !== 'chromium' && mcpBrowser !== 'chrome', 'chrome:// pages are chromium-specific'); - await cli('open', server.HELLO_WORLD); - const { output } = await cli('goto', 'chrome://extensions/'); - expect(output).toContain('No open tabs. Navigate to a URL to create one.'); -});