From 3b43615f66fb4d65260ef282a8fec6ea6a16107d Mon Sep 17 00:00:00 2001 From: Miguel Angel Asencio Hurtado Date: Tue, 2 Mar 2021 16:16:26 +0100 Subject: [PATCH 1/5] fix: export assignment cannot be used in a module with other exported elements --- packages/array-max/types.d.ts | 6 ++++-- packages/array-min/types.d.ts | 6 ++++-- packages/array-normed/types.d.ts | 6 ++++-- packages/array-rescale/types.d.ts | 5 +++-- 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/packages/array-max/types.d.ts b/packages/array-max/types.d.ts index 8ec347e..7453489 100644 --- a/packages/array-max/types.d.ts +++ b/packages/array-max/types.d.ts @@ -1,4 +1,4 @@ -declare module 'ml-array-max' { +declare module ArrayMax { export interface ArrayMaxOptions { /** * Start index (inclusive) for the slice within which we look for the maximum. @@ -17,5 +17,7 @@ declare module 'ml-array-max' { array: ArrayLike, options?: ArrayMaxOptions, ): number; - export = arrayMax; } + +export = ArrayMax.arrayMax; + diff --git a/packages/array-min/types.d.ts b/packages/array-min/types.d.ts index 2635d87..0aff25f 100644 --- a/packages/array-min/types.d.ts +++ b/packages/array-min/types.d.ts @@ -1,4 +1,4 @@ -declare module 'ml-array-min' { +declare module ArrayMin { export interface ArrayMinOptions { /** * Start index (inclusive) for the slice within which we look for the minimum. @@ -17,5 +17,7 @@ declare module 'ml-array-min' { array: ArrayLike, options?: ArrayMinOptions, ): number; - export = arrayMin; } + +export = ArrayMin.arrayMin; + diff --git a/packages/array-normed/types.d.ts b/packages/array-normed/types.d.ts index d7c5e3c..565595f 100644 --- a/packages/array-normed/types.d.ts +++ b/packages/array-normed/types.d.ts @@ -1,4 +1,4 @@ -declare module 'ml-array-normed' { +declare module ArrayNormed { export interface ArrayNormedOptions> { /** * @default 'absolute' @@ -27,5 +27,7 @@ declare module 'ml-array-normed' { array: T, options?: ArrayNormedOptions, ): number[]; - export = arrayNormed; } + +export = ArrayNormed.arrayNormed; + diff --git a/packages/array-rescale/types.d.ts b/packages/array-rescale/types.d.ts index 8c29e29..5227435 100644 --- a/packages/array-rescale/types.d.ts +++ b/packages/array-rescale/types.d.ts @@ -1,4 +1,4 @@ -declare module 'ml-array-rescale' { +declare module ArrayRescale { export interface ArrayRescaleOptions> { /** * @default 0 @@ -26,5 +26,6 @@ declare module 'ml-array-rescale' { array: T, options?: ArrayRescaleOptions, ): number; - export = arrayRescale; } + +export = ArrayRescale.arrayRescale; From c81d8f03a369aab2769d1200b5161c4ff622770f Mon Sep 17 00:00:00 2001 From: Miguel Angel Asencio Hurtado Date: Tue, 2 Mar 2021 16:52:35 +0100 Subject: [PATCH 2/5] chore: use namespace instead modules --- packages/array-max/types.d.ts | 4 ++-- packages/array-min/types.d.ts | 4 ++-- packages/array-normed/types.d.ts | 4 ++-- packages/array-rescale/types.d.ts | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/array-max/types.d.ts b/packages/array-max/types.d.ts index 7453489..c79566f 100644 --- a/packages/array-max/types.d.ts +++ b/packages/array-max/types.d.ts @@ -1,4 +1,4 @@ -declare module ArrayMax { +declare namespace ArrayMax { export interface ArrayMaxOptions { /** * Start index (inclusive) for the slice within which we look for the maximum. @@ -19,5 +19,5 @@ declare module ArrayMax { ): number; } -export = ArrayMax.arrayMax; +export = ArrayMax; diff --git a/packages/array-min/types.d.ts b/packages/array-min/types.d.ts index 0aff25f..b9e10c8 100644 --- a/packages/array-min/types.d.ts +++ b/packages/array-min/types.d.ts @@ -1,4 +1,4 @@ -declare module ArrayMin { +declare namespace ArrayMin { export interface ArrayMinOptions { /** * Start index (inclusive) for the slice within which we look for the minimum. @@ -19,5 +19,5 @@ declare module ArrayMin { ): number; } -export = ArrayMin.arrayMin; +export = ArrayMin; diff --git a/packages/array-normed/types.d.ts b/packages/array-normed/types.d.ts index 565595f..dfa1867 100644 --- a/packages/array-normed/types.d.ts +++ b/packages/array-normed/types.d.ts @@ -1,4 +1,4 @@ -declare module ArrayNormed { +declare namespace ArrayNormed { export interface ArrayNormedOptions> { /** * @default 'absolute' @@ -29,5 +29,5 @@ declare module ArrayNormed { ): number[]; } -export = ArrayNormed.arrayNormed; +export = ArrayNormed; diff --git a/packages/array-rescale/types.d.ts b/packages/array-rescale/types.d.ts index 5227435..b800f56 100644 --- a/packages/array-rescale/types.d.ts +++ b/packages/array-rescale/types.d.ts @@ -1,4 +1,4 @@ -declare module ArrayRescale { +declare namespace ArrayRescale { export interface ArrayRescaleOptions> { /** * @default 0 @@ -28,4 +28,4 @@ declare module ArrayRescale { ): number; } -export = ArrayRescale.arrayRescale; +export = ArrayRescale; From 38db8a8ce8cf6645d1c6227140f3bf4ff3846344 Mon Sep 17 00:00:00 2001 From: Miguel Angel Asencio Hurtado Date: Tue, 2 Mar 2021 17:47:04 +0100 Subject: [PATCH 3/5] fix: options type exported correctly --- packages/array-max/types.d.ts | 17 ++++++++--------- packages/array-min/types.d.ts | 17 ++++++++--------- packages/array-normed/types.d.ts | 17 ++++++++--------- packages/array-rescale/types.d.ts | 16 ++++++++-------- 4 files changed, 32 insertions(+), 35 deletions(-) diff --git a/packages/array-max/types.d.ts b/packages/array-max/types.d.ts index c79566f..1ffd10f 100644 --- a/packages/array-max/types.d.ts +++ b/packages/array-max/types.d.ts @@ -9,15 +9,14 @@ declare namespace ArrayMax { */ toIndex?: number; } - - /** - * Computes the maximum of the given values. - */ - function arrayMax( - array: ArrayLike, - options?: ArrayMaxOptions, - ): number; } -export = ArrayMax; +/** + * Computes the maximum of the given values. + */ +declare function ArrayMax( + array: ArrayLike, + options?: ArrayMax.ArrayMaxOptions, +): number; +export = ArrayMax; diff --git a/packages/array-min/types.d.ts b/packages/array-min/types.d.ts index b9e10c8..1cb988b 100644 --- a/packages/array-min/types.d.ts +++ b/packages/array-min/types.d.ts @@ -9,15 +9,14 @@ declare namespace ArrayMin { */ toIndex?: number; } - - /** - * Computes the minimum of the given values. - */ - function arrayMin( - array: ArrayLike, - options?: ArrayMinOptions, - ): number; } -export = ArrayMin; +/** + * Computes the minimum of the given values. + */ +declare function ArrayMin( + array: ArrayLike, + options?: ArrayMin.ArrayMinOptions, +): number; +export = ArrayMin; diff --git a/packages/array-normed/types.d.ts b/packages/array-normed/types.d.ts index dfa1867..250e878 100644 --- a/packages/array-normed/types.d.ts +++ b/packages/array-normed/types.d.ts @@ -19,15 +19,14 @@ declare namespace ArrayNormed { */ output?: T; } - - /** - * Normalize the values of the given array. - */ - function arrayNormed>( - array: T, - options?: ArrayNormedOptions, - ): number[]; } -export = ArrayNormed; +/** + * Normalize the values of the given array. + */ +declare function ArrayNormed>( + array: T, + options?: ArrayNormed.ArrayNormedOptions, +): number[]; +export = ArrayNormed; diff --git a/packages/array-rescale/types.d.ts b/packages/array-rescale/types.d.ts index b800f56..2b73871 100644 --- a/packages/array-rescale/types.d.ts +++ b/packages/array-rescale/types.d.ts @@ -18,14 +18,14 @@ declare namespace ArrayRescale { */ output?: T; } - - /** - * Rescale an array into a range. - */ - function arrayRescale>( - array: T, - options?: ArrayRescaleOptions, - ): number; } +/** + * Rescale an array into a range. + */ +declare function ArrayRescale>( + array: T, + options?: ArrayRescale.ArrayRescaleOptions, +): number; + export = ArrayRescale; From 3f8bbd59db33852b40f0aa75091878d40d232bbb Mon Sep 17 00:00:00 2001 From: Miguel Angel Asencio Hurtado Date: Wed, 3 Mar 2021 09:48:22 +0100 Subject: [PATCH 4/5] chore: rename to match auto-import --- packages/array-max/types.d.ts | 8 ++++---- packages/array-min/types.d.ts | 8 ++++---- packages/array-normed/types.d.ts | 4 ++-- packages/array-rescale/types.d.ts | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/array-max/types.d.ts b/packages/array-max/types.d.ts index 1ffd10f..9137a59 100644 --- a/packages/array-max/types.d.ts +++ b/packages/array-max/types.d.ts @@ -1,4 +1,4 @@ -declare namespace ArrayMax { +declare namespace mlArrayMax { export interface ArrayMaxOptions { /** * Start index (inclusive) for the slice within which we look for the maximum. @@ -14,9 +14,9 @@ declare namespace ArrayMax { /** * Computes the maximum of the given values. */ -declare function ArrayMax( +declare function mlArrayMax( array: ArrayLike, - options?: ArrayMax.ArrayMaxOptions, + options?: mlArrayMax.ArrayMaxOptions, ): number; -export = ArrayMax; +export = mlArrayMax; diff --git a/packages/array-min/types.d.ts b/packages/array-min/types.d.ts index 1cb988b..a902a77 100644 --- a/packages/array-min/types.d.ts +++ b/packages/array-min/types.d.ts @@ -1,4 +1,4 @@ -declare namespace ArrayMin { +declare namespace mlArrayMin { export interface ArrayMinOptions { /** * Start index (inclusive) for the slice within which we look for the minimum. @@ -14,9 +14,9 @@ declare namespace ArrayMin { /** * Computes the minimum of the given values. */ -declare function ArrayMin( +declare function mlArrayMin( array: ArrayLike, - options?: ArrayMin.ArrayMinOptions, + options?: mlArrayMin.ArrayMinOptions, ): number; -export = ArrayMin; +export = mlArrayMin; diff --git a/packages/array-normed/types.d.ts b/packages/array-normed/types.d.ts index 250e878..9b01741 100644 --- a/packages/array-normed/types.d.ts +++ b/packages/array-normed/types.d.ts @@ -1,4 +1,4 @@ -declare namespace ArrayNormed { +declare namespace mlArrayNormed { export interface ArrayNormedOptions> { /** * @default 'absolute' @@ -26,7 +26,7 @@ declare namespace ArrayNormed { */ declare function ArrayNormed>( array: T, - options?: ArrayNormed.ArrayNormedOptions, + options?: mlArrayNormed.ArrayNormedOptions, ): number[]; export = ArrayNormed; diff --git a/packages/array-rescale/types.d.ts b/packages/array-rescale/types.d.ts index 2b73871..f615969 100644 --- a/packages/array-rescale/types.d.ts +++ b/packages/array-rescale/types.d.ts @@ -1,4 +1,4 @@ -declare namespace ArrayRescale { +declare namespace mlArrayRescale { export interface ArrayRescaleOptions> { /** * @default 0 @@ -23,9 +23,9 @@ declare namespace ArrayRescale { /** * Rescale an array into a range. */ -declare function ArrayRescale>( +declare function mlArrayRescale>( array: T, - options?: ArrayRescale.ArrayRescaleOptions, + options?: mlArrayRescale.ArrayRescaleOptions, ): number; -export = ArrayRescale; +export = mlArrayRescale; From f1a3c68acb3f345b443ed7b731edc1e46f734deb Mon Sep 17 00:00:00 2001 From: Miguel Angel Asencio Hurtado Date: Wed, 3 Mar 2021 10:46:17 +0100 Subject: [PATCH 5/5] Update packages/array-normed/types.d.ts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Michaël Zasso --- packages/array-normed/types.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/array-normed/types.d.ts b/packages/array-normed/types.d.ts index 9b01741..851f817 100644 --- a/packages/array-normed/types.d.ts +++ b/packages/array-normed/types.d.ts @@ -24,9 +24,9 @@ declare namespace mlArrayNormed { /** * Normalize the values of the given array. */ -declare function ArrayNormed>( +declare function mlArrayNormed>( array: T, options?: mlArrayNormed.ArrayNormedOptions, ): number[]; -export = ArrayNormed; +export = mlArrayNormed;