From cb7464288c01287734018042975ee65f558fc93f Mon Sep 17 00:00:00 2001 From: Guillaume Favelier Date: Fri, 6 Mar 2020 09:33:04 +0100 Subject: [PATCH 1/3] Change window title --- mne/viz/_brain/_brain.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mne/viz/_brain/_brain.py b/mne/viz/_brain/_brain.py index 40bad8a7dee..84eeb82c97b 100644 --- a/mne/viz/_brain/_brain.py +++ b/mne/viz/_brain/_brain.py @@ -143,8 +143,7 @@ def __init__(self, subject_id, hemi, surf, title=None, foreground=None, figure=None, subjects_dir=None, views=['lateral'], offset=True, show_toolbar=False, offscreen=False, interaction=None, units='mm'): - from ..backends.renderer import (_get_renderer, _check_3d_figure, - _set_3d_title) + from ..backends.renderer import _get_renderer, _check_3d_figure from matplotlib.colors import colorConverter if interaction is not None: @@ -200,10 +199,9 @@ def __init__(self, subject_id, hemi, surf, title=None, if figure is not None and not isinstance(figure, int): _check_3d_figure(figure) - self._renderer = _get_renderer(size=fig_size, bgcolor=background, + self._renderer = _get_renderer(name=title, size=fig_size, + bgcolor=background, shape=(n_row, n_col), fig=figure) - if self._title is not None: - _set_3d_title(figure=self._renderer.scene(), title=self._title) for h in self._hemis: # Initialize a Surface object as the geometry From e82881d1a3be88a178825eafc4be019e118ef287 Mon Sep 17 00:00:00 2001 From: Guillaume Favelier Date: Fri, 6 Mar 2020 09:52:56 +0100 Subject: [PATCH 2/3] Use subject_id as header --- mne/viz/_brain/_brain.py | 7 +++++-- mne/viz/backends/_pyvista.py | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/mne/viz/_brain/_brain.py b/mne/viz/_brain/_brain.py index 84eeb82c97b..6fe8318dc9b 100644 --- a/mne/viz/_brain/_brain.py +++ b/mne/viz/_brain/_brain.py @@ -143,7 +143,8 @@ def __init__(self, subject_id, hemi, surf, title=None, foreground=None, figure=None, subjects_dir=None, views=['lateral'], offset=True, show_toolbar=False, offscreen=False, interaction=None, units='mm'): - from ..backends.renderer import _get_renderer, _check_3d_figure + from ..backends.renderer import (_get_renderer, _check_3d_figure, + _set_3d_title) from matplotlib.colors import colorConverter if interaction is not None: @@ -199,9 +200,11 @@ def __init__(self, subject_id, hemi, surf, title=None, if figure is not None and not isinstance(figure, int): _check_3d_figure(figure) - self._renderer = _get_renderer(name=title, size=fig_size, + self._renderer = _get_renderer(name=subject_id, size=fig_size, bgcolor=background, shape=(n_row, n_col), fig=figure) + if self._title is not None: + _set_3d_title(figure=self._renderer.scene(), title=self._title) for h in self._hemis: # Initialize a Surface object as the geometry diff --git a/mne/viz/backends/_pyvista.py b/mne/viz/backends/_pyvista.py index 993f86449dc..500a13b64e5 100644 --- a/mne/viz/backends/_pyvista.py +++ b/mne/viz/backends/_pyvista.py @@ -550,7 +550,7 @@ def _set_3d_view(figure, azimuth, elevation, focalpoint, distance): position, cen, view_up] -def _set_3d_title(figure, title, size=40): +def _set_3d_title(figure, title, size=16): with warnings.catch_warnings(): warnings.filterwarnings("ignore", category=FutureWarning) figure.plotter.add_text(title, font_size=size, color='white') From bccea365e6800a6cfdfdd4d9d0b3a0788137c540 Mon Sep 17 00:00:00 2001 From: Guillaume Favelier Date: Fri, 6 Mar 2020 12:08:35 +0100 Subject: [PATCH 3/3] Move _set_3d_title --- mne/viz/_brain/_brain.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mne/viz/_brain/_brain.py b/mne/viz/_brain/_brain.py index 6fe8318dc9b..d6706b9482c 100644 --- a/mne/viz/_brain/_brain.py +++ b/mne/viz/_brain/_brain.py @@ -203,8 +203,6 @@ def __init__(self, subject_id, hemi, surf, title=None, self._renderer = _get_renderer(name=subject_id, size=fig_size, bgcolor=background, shape=(n_row, n_col), fig=figure) - if self._title is not None: - _set_3d_title(figure=self._renderer.scene(), title=self._title) for h in self._hemis: # Initialize a Surface object as the geometry @@ -237,6 +235,10 @@ def __init__(self, subject_id, hemi, surf, title=None, self._hemi_meshes[h] = mesh self._renderer.set_camera(azimuth=views_dict[v].azim, elevation=views_dict[v].elev) + + if self._title is not None: + _set_3d_title(figure=self._renderer.scene(), title=self._title) + # Force rendering self._renderer.show()