From 3687415c601bb470a7f38121120786e7bce34d50 Mon Sep 17 00:00:00 2001
From: Nat Budin <natbudin@gmail.com>
Date: Fri, 7 Aug 2026 18:59:25 -0700
Subject: [PATCH] Deprecate and remove remaining bucket key-based
 GraphQL/Liquid surface (#11896)

Most of the fields this issue targets were already deprecation_reason-marked
(the four Signup-family types' bucketKey/requestedBucketKey, and all six
mutations' bucket_key/requested_bucket_key arguments) -- so the actual work
here is narrower than the issue's own background section:

- Remove BucketKeyMappingInputType#from_key entirely (not just deprecate --
  a removed bucket is always a persisted row with a real id already, unlike
  to_key's bucket, which may be newly created in the same edit and have no
  id yet). This required converting BucketKeyRemappingModal.tsx/
  useBucketKeyRemapping.tsx to submit from_bucket_id instead, since they
  previously always sent from_key.
- Deprecate RegistrationPolicyBucketType#key (the one field the issue
  flagged as not yet deprecated). This surfaces new
  @graphql-eslint/no-deprecated warnings on the many places that still
  legitimately read key for editing/remapping -- expected, not something
  this issue addresses.
- Remove RegistrationPolicy::BucketDrop#key's delegate (confirmed zero
  real-world Liquid usage).
- Delete the dead RegistrationPolicyInputType/RegistrationPolicyBucketInputType
  (referenced by nothing, not even present in the generated schema).

Deliberately not removing the already-deprecated bucketKey/requestedBucketKey
fields or mutation arguments yet -- the issue calls for that to wait on a
deprecation window passing, which is a timing/process decision rather than
something to execute in this PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 app/graphql/mutations/update_event.rb         |  8 +++----
 .../types/bucket_key_mapping_input_type.rb    |  6 -----
 .../registration_policy_bucket_input_type.rb  | 13 ----------
 .../types/registration_policy_bucket_type.rb  |  6 ++++-
 .../types/registration_policy_input_type.rb   |  5 ----
 .../EventAdmin/BucketKeyRemappingModal.tsx    | 24 +++++++++++--------
 .../EventAdmin/mutations.generated.ts         |  5 ----
 .../EventAdmin/useBucketKeyRemapping.tsx      | 23 +++++++++++-------
 .../mutations.generated.ts                    |  5 ----
 app/javascript/graphqlTypes.generated.ts      | 10 ++++----
 .../registration_policy/bucket_drop.rb        |  3 ---
 schema.graphql                                |  7 +-----
 schema.json                                   | 16 ++-----------
 .../BucketKeyRemappingModal.test.tsx          | 14 +++++------
 14 files changed, 52 insertions(+), 93 deletions(-)
 delete mode 100644 app/graphql/types/registration_policy_bucket_input_type.rb
 delete mode 100644 app/graphql/types/registration_policy_input_type.rb

diff --git a/app/graphql/mutations/update_event.rb b/app/graphql/mutations/update_event.rb
index 44303883832..a66672af6bd 100644
--- a/app/graphql/mutations/update_event.rb
+++ b/app/graphql/mutations/update_event.rb
@@ -39,16 +39,16 @@ def apply_registration_policy(event, registration_policy_attributes, bucket_key_
   end
 
   # EventChangeRegistrationPolicyService still works entirely in terms of from_key/to_key (see the
-  # comment on that service). This resolves incoming from_bucket_id/to_bucket_id args (only usable
-  # when the destination bucket already exists, since a bucket being newly created in this same
-  # edit has no id yet) down to that shape.
+  # comment on that service). This resolves incoming from_bucket_id/to_bucket_id args down to that
+  # shape -- to_bucket_id is only usable when the destination bucket already exists, since a
+  # bucket being newly created in this same edit has no id yet, so to_key is still accepted too.
   def resolve_bucket_key_mappings(event, bucket_key_mappings)
     (bucket_key_mappings || []).map { |mapping| resolve_bucket_key_mapping(event, mapping.to_h) }
   end
 
   def resolve_bucket_key_mapping(event, mapping)
     {
-      from_key: mapping[:from_key] || bucket_key_for_id(event, mapping[:from_bucket_id]),
+      from_key: bucket_key_for_id(event, mapping[:from_bucket_id]),
       to_key: mapping[:to_key] || bucket_key_for_id(event, mapping[:to_bucket_id])
     }
   end
diff --git a/app/graphql/types/bucket_key_mapping_input_type.rb b/app/graphql/types/bucket_key_mapping_input_type.rb
index fa5690b21b3..02da6024059 100644
--- a/app/graphql/types/bucket_key_mapping_input_type.rb
+++ b/app/graphql/types/bucket_key_mapping_input_type.rb
@@ -7,12 +7,6 @@ class Types::BucketKeyMappingInputType < Types::BaseInputObject
            required: false,
            camelize: true,
            description: "The id of the old bucket being removed or changed"
-  argument :from_key,
-           String,
-           required: false,
-           camelize: false,
-           deprecation_reason: "Use from_bucket_id instead",
-           description: "The old bucket key being removed or changed"
   argument :to_bucket_id, ID, required: false, camelize: true, description: <<~MARKDOWN
              The id of the new bucket to map to (nil means no preference). Only usable when mapping
              to a bucket that already exists -- mapping to a bucket being newly created in the same
diff --git a/app/graphql/types/registration_policy_bucket_input_type.rb b/app/graphql/types/registration_policy_bucket_input_type.rb
deleted file mode 100644
index e91077a4ee1..00000000000
--- a/app/graphql/types/registration_policy_bucket_input_type.rb
+++ /dev/null
@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-class Types::RegistrationPolicyBucketInputType < Types::BaseInputObject
-  argument :anything, Boolean, required: false
-  argument :description, String, required: false
-  argument :expose_attendees, Boolean, required: false, camelize: false
-  argument :key, String, required: true
-  argument :minimum_slots, Integer, required: false, camelize: false
-  argument :name, String, required: false
-  argument :not_counted, Boolean, required: false, camelize: false
-  argument :preferred_slots, Integer, required: false, camelize: false
-  argument :slots_limited, Boolean, required: false, camelize: false
-  argument :total_slots, Integer, required: false, camelize: false
-end
diff --git a/app/graphql/types/registration_policy_bucket_type.rb b/app/graphql/types/registration_policy_bucket_type.rb
index c65f4584ee9..2493a761315 100644
--- a/app/graphql/types/registration_policy_bucket_type.rb
+++ b/app/graphql/types/registration_policy_bucket_type.rb
@@ -4,7 +4,11 @@ class Types::RegistrationPolicyBucketType < Types::BaseObject
 
   field :description, String, null: true, description: "A long-form description for the bucket"
   field :id, ID, null: false, description: "The ID of this bucket"
-  field :key, String, null: false, description: "The unique string identifier for this bucket"
+  field :key,
+        String,
+        null: false,
+        deprecation_reason: "Use id instead",
+        description: "The unique string identifier for this bucket"
   field :minimum_slots, Integer, null: true, description: "The minimum number of attendees needed for this bucket"
   field :name, String, null: false, description: "The name of this bucket"
   field :preferred_slots, Integer, null: true, description: "The preferred number of attendees for this bucket"
diff --git a/app/graphql/types/registration_policy_input_type.rb b/app/graphql/types/registration_policy_input_type.rb
deleted file mode 100644
index 6ac3864d5ba..00000000000
--- a/app/graphql/types/registration_policy_input_type.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-class Types::RegistrationPolicyInputType < Types::BaseInputObject
-  argument :buckets, [Types::RegistrationPolicyBucketInputType], required: false
-  argument :prevent_no_preference_signups, Boolean, required: false, camelize: false
-end
diff --git a/app/javascript/EventAdmin/BucketKeyRemappingModal.tsx b/app/javascript/EventAdmin/BucketKeyRemappingModal.tsx
index 27b40623cf3..2c5aeecae2c 100644
--- a/app/javascript/EventAdmin/BucketKeyRemappingModal.tsx
+++ b/app/javascript/EventAdmin/BucketKeyRemappingModal.tsx
@@ -10,9 +10,13 @@ type BucketOption = {
   name?: string | null;
 };
 
+// A removed bucket is always a persisted row, so it always has a real id -- unlike a bucket in
+// newPolicyBuckets, which might have been added in the current, not-yet-saved edit.
+type RemovedBucketOption = BucketOption & { id: string };
+
 export type BucketKeyRemappingModalProps = {
   visible: boolean;
-  removedBuckets: BucketOption[];
+  removedBuckets: RemovedBucketOption[];
   newPolicyBuckets: BucketOption[];
   preventNoPreferenceSignups: boolean;
   onConfirm: (mappings: BucketKeyMappingInput[]) => Promise<void>;
@@ -42,22 +46,22 @@ function BucketKeyRemappingModal({
   const [prevRemovedBuckets, setPrevRemovedBuckets] = useState(removedBuckets);
   if (prevRemovedBuckets !== removedBuckets) {
     setPrevRemovedBuckets(removedBuckets);
-    setMappings(Object.fromEntries(removedBuckets.map((bucket) => [bucket.key, null])));
+    setMappings(Object.fromEntries(removedBuckets.map((bucket) => [bucket.id, null])));
   }
 
-  const setMapping = (fromKey: string, toKey: string | null) => {
-    setMappings((prev) => ({ ...prev, [fromKey]: toKey }));
+  const setMapping = (fromBucketId: string, toKey: string | null) => {
+    setMappings((prev) => ({ ...prev, [fromBucketId]: toKey }));
   };
 
   // When the new policy disallows no-preference signups, mapping a removed bucket to "no
   // preference" would leave affected signups/requests with a null requested_bucket_id that the
   // policy no longer permits new signups to have -- so every row needs an explicit bucket chosen
   // before this can be confirmed.
-  const canConfirm = !preventNoPreferenceSignups || removedBuckets.every((bucket) => mappings[bucket.key]);
+  const canConfirm = !preventNoPreferenceSignups || removedBuckets.every((bucket) => mappings[bucket.id]);
 
   const handleConfirm = async () => {
-    const bucketKeyMappings: BucketKeyMappingInput[] = Object.entries(mappings).map(([fromKey, toKey]) => ({
-      from_key: fromKey,
+    const bucketKeyMappings: BucketKeyMappingInput[] = Object.entries(mappings).map(([fromBucketId, toKey]) => ({
+      from_bucket_id: fromBucketId,
       to_key: toKey ?? undefined,
     }));
     setIsSubmitting(true);
@@ -90,13 +94,13 @@ function BucketKeyRemappingModal({
           </thead>
           <tbody>
             {removedBuckets.map((bucket) => (
-              <tr key={bucket.key}>
+              <tr key={bucket.id}>
                 <td>{bucket.name}</td>
                 <td>
                   <select
                     className="form-select"
-                    value={mappings[bucket.key] ?? ''}
-                    onChange={(e) => setMapping(bucket.key, e.target.value || null)}
+                    value={mappings[bucket.id] ?? ''}
+                    onChange={(e) => setMapping(bucket.id, e.target.value || null)}
                     disabled={isSubmitting}
                   >
                     {preventNoPreferenceSignups ? (
diff --git a/app/javascript/EventAdmin/mutations.generated.ts b/app/javascript/EventAdmin/mutations.generated.ts
index 57b1c65e057..98d328527b4 100644
--- a/app/javascript/EventAdmin/mutations.generated.ts
+++ b/app/javascript/EventAdmin/mutations.generated.ts
@@ -10,11 +10,6 @@ import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/
 export type BucketKeyMappingInput = {
   /** The id of the old bucket being removed or changed */
   fromBucketId?: string | number | null | undefined;
-  /**
-   * The old bucket key being removed or changed
-   * @deprecated Use from_bucket_id instead
-   */
-  from_key?: string | null | undefined;
   /**
    * The id of the new bucket to map to (nil means no preference). Only usable when mapping
    * to a bucket that already exists -- mapping to a bucket being newly created in the same
diff --git a/app/javascript/EventAdmin/useBucketKeyRemapping.tsx b/app/javascript/EventAdmin/useBucketKeyRemapping.tsx
index 28c899e2d1b..baeb649c474 100644
--- a/app/javascript/EventAdmin/useBucketKeyRemapping.tsx
+++ b/app/javascript/EventAdmin/useBucketKeyRemapping.tsx
@@ -2,17 +2,24 @@ import { useState, useCallback, useMemo, useRef } from 'react';
 import { BucketKeyMappingInput } from '../graphqlTypes.generated';
 import { BucketKeyRemappingModalProps } from './BucketKeyRemappingModal';
 
-type Bucket = { key: string; name?: string | null };
-type RegistrationPolicyLike = { buckets?: Bucket[]; prevent_no_preference_signups?: boolean } | null;
+type DraftBucket = { key: string; name?: string | null };
+// A bucket read from the event's already-persisted form response (as opposed to the current,
+// possibly-unsaved draft) always has a real id, since RegistrationPolicyBucket#as_json includes
+// it -- unlike a brand-new bucket in the draft, which has no id until the edit is saved.
+type PersistedBucket = DraftBucket & { id: string };
+type RegistrationPolicyLike<BucketType> = { buckets?: BucketType[]; prevent_no_preference_signups?: boolean } | null;
 
-function bucketsFromFormResponseAttrs(formResponseAttrs: { registration_policy?: unknown }): Bucket[] {
-  return (formResponseAttrs.registration_policy as RegistrationPolicyLike)?.buckets ?? [];
+function bucketsFromFormResponseAttrs<BucketType>(formResponseAttrs: { registration_policy?: unknown }): BucketType[] {
+  return (formResponseAttrs.registration_policy as RegistrationPolicyLike<BucketType>)?.buckets ?? [];
 }
 
 function preventNoPreferenceSignupsFromFormResponseAttrs(formResponseAttrs: {
   registration_policy?: unknown;
 }): boolean {
-  return (formResponseAttrs.registration_policy as RegistrationPolicyLike)?.prevent_no_preference_signups ?? false;
+  return (
+    (formResponseAttrs.registration_policy as RegistrationPolicyLike<DraftBucket>)?.prevent_no_preference_signups ??
+    false
+  );
 }
 
 type UseBucketKeyRemappingOptions = {
@@ -26,11 +33,11 @@ type UseBucketKeyRemappingOptions = {
 
 export default function useBucketKeyRemapping({ event, initialEvent, onSubmit }: UseBucketKeyRemappingOptions) {
   const [remappingModalVisible, setRemappingModalVisible] = useState(false);
-  const [removedBucketsNeedingRemapping, setRemovedBucketsNeedingRemapping] = useState<Bucket[]>([]);
+  const [removedBucketsNeedingRemapping, setRemovedBucketsNeedingRemapping] = useState<PersistedBucket[]>([]);
   const pendingResolveRef = useRef<(() => void) | null>(null);
   const pendingRejectRef = useRef<((reason?: unknown) => void) | null>(null);
 
-  const newPolicyBuckets = useMemo(() => bucketsFromFormResponseAttrs(event.form_response_attrs), [event]);
+  const newPolicyBuckets = useMemo(() => bucketsFromFormResponseAttrs<DraftBucket>(event.form_response_attrs), [event]);
   const preventNoPreferenceSignups = useMemo(
     () => preventNoPreferenceSignupsFromFormResponseAttrs(event.form_response_attrs),
     [event],
@@ -38,7 +45,7 @@ export default function useBucketKeyRemapping({ event, initialEvent, onSubmit }:
 
   const updateEvent = useCallback(async () => {
     const currentBucketKeys = new Set(newPolicyBuckets.map((b) => b.key));
-    const originalBuckets = bucketsFromFormResponseAttrs(initialEvent.form_response_attrs);
+    const originalBuckets = bucketsFromFormResponseAttrs<PersistedBucket>(initialEvent.form_response_attrs);
     const keysWithRecords = new Set(initialEvent.bucket_keys_with_pending_signups_or_requests);
 
     const removedBuckets = originalBuckets.filter((b) => !currentBucketKeys.has(b.key) && keysWithRecords.has(b.key));
diff --git a/app/javascript/EventsApp/StandaloneEditEvent/mutations.generated.ts b/app/javascript/EventsApp/StandaloneEditEvent/mutations.generated.ts
index 7c050755563..1b32c235052 100644
--- a/app/javascript/EventsApp/StandaloneEditEvent/mutations.generated.ts
+++ b/app/javascript/EventsApp/StandaloneEditEvent/mutations.generated.ts
@@ -10,11 +10,6 @@ import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/
 export type BucketKeyMappingInput = {
   /** The id of the old bucket being removed or changed */
   fromBucketId?: string | number | null | undefined;
-  /**
-   * The old bucket key being removed or changed
-   * @deprecated Use from_bucket_id instead
-   */
-  from_key?: string | null | undefined;
   /**
    * The id of the new bucket to map to (nil means no preference). Only usable when mapping
    * to a bucket that already exists -- mapping to a bucket being newly created in the same
diff --git a/app/javascript/graphqlTypes.generated.ts b/app/javascript/graphqlTypes.generated.ts
index 133855a5f5b..ce67da03ab2 100644
--- a/app/javascript/graphqlTypes.generated.ts
+++ b/app/javascript/graphqlTypes.generated.ts
@@ -301,11 +301,6 @@ export type AuthorizedApplication = {
 export type BucketKeyMappingInput = {
   /** The id of the old bucket being removed or changed */
   fromBucketId?: InputMaybe<Scalars['ID']['input']>;
-  /**
-   * The old bucket key being removed or changed
-   * @deprecated Use from_bucket_id instead
-   */
-  from_key?: InputMaybe<Scalars['String']['input']>;
   /**
    * The id of the new bucket to map to (nil means no preference). Only usable when mapping
    * to a bucket that already exists -- mapping to a bucket being newly created in the same
@@ -5563,7 +5558,10 @@ export type RegistrationPolicyBucket = {
   expose_attendees: Scalars['Boolean']['output'];
   /** The ID of this bucket */
   id: Scalars['ID']['output'];
-  /** The unique string identifier for this bucket */
+  /**
+   * The unique string identifier for this bucket
+   * @deprecated Use id instead
+   */
   key: Scalars['String']['output'];
   /** The minimum number of attendees needed for this bucket */
   minimum_slots?: Maybe<Scalars['Int']['output']>;
diff --git a/app/liquid_drops/registration_policy/bucket_drop.rb b/app/liquid_drops/registration_policy/bucket_drop.rb
index 6c24493ad58..1b4c03432a2 100644
--- a/app/liquid_drops/registration_policy/bucket_drop.rb
+++ b/app/liquid_drops/registration_policy/bucket_drop.rb
@@ -6,8 +6,6 @@ class RegistrationPolicy::BucketDrop < Liquid::Drop
 
   # @!method id
   #   @return [Integer] The numeric database id of this bucket
-  # @!method key
-  #   @return [String] The unique string identifier for this bucket
   # @!method name
   #   @return [String] The name of this bucket
   # @!method description
@@ -31,7 +29,6 @@ class RegistrationPolicy::BucketDrop < Liquid::Drop
   #   @return [Boolean] Whether or not to allow other attendees to see that a person is in this
   #                     bucket in the signup summary page
   delegate :id,
-           :key,
            :name,
            :description,
            :minimum_slots,
diff --git a/schema.graphql b/schema.graphql
index 4831cbb2387..8c8e97f145f 100644
--- a/schema.graphql
+++ b/schema.graphql
@@ -237,11 +237,6 @@ input BucketKeyMappingInput {
   """
   fromBucketId: ID
 
-  """
-  The old bucket key being removed or changed
-  """
-  from_key: String @deprecated(reason: "Use from_bucket_id instead")
-
   """
   The id of the new bucket to map to (nil means no preference). Only usable when mapping
   to a bucket that already exists -- mapping to a bucket being newly created in the same
@@ -7363,7 +7358,7 @@ type RegistrationPolicyBucket {
   """
   The unique string identifier for this bucket
   """
-  key: String!
+  key: String! @deprecated(reason: "Use id instead")
 
   """
   The minimum number of attendees needed for this bucket
diff --git a/schema.json b/schema.json
index 963bec38954..83a74f38276 100644
--- a/schema.json
+++ b/schema.json
@@ -1898,18 +1898,6 @@
               "isDeprecated": false,
               "deprecationReason": null
             },
-            {
-              "name": "from_key",
-              "description": "The old bucket key being removed or changed",
-              "type": {
-                "kind": "SCALAR",
-                "name": "String",
-                "ofType": null
-              },
-              "defaultValue": null,
-              "isDeprecated": true,
-              "deprecationReason": "Use from_bucket_id instead"
-            },
             {
               "name": "toBucketId",
               "description": "The id of the new bucket to map to (nil means no preference). Only usable when mapping\nto a bucket that already exists -- mapping to a bucket being newly created in the same\nedit still requires to_key, since it has no id yet.\n",
@@ -29984,8 +29972,8 @@
                   "ofType": null
                 }
               },
-              "isDeprecated": false,
-              "deprecationReason": null,
+              "isDeprecated": true,
+              "deprecationReason": "Use id instead",
               "args": []
             },
             {
diff --git a/test/javascript/EventAdmin/BucketKeyRemappingModal.test.tsx b/test/javascript/EventAdmin/BucketKeyRemappingModal.test.tsx
index 01942665f04..24dd53697f7 100644
--- a/test/javascript/EventAdmin/BucketKeyRemappingModal.test.tsx
+++ b/test/javascript/EventAdmin/BucketKeyRemappingModal.test.tsx
@@ -53,7 +53,7 @@ describe('BucketKeyRemappingModal', () => {
       wrap(
         <BucketKeyRemappingModal
           visible
-          removedBuckets={[{ key: 'signups', name: 'Cats' }]}
+          removedBuckets={[{ id: '1', key: 'signups', name: 'Cats' }]}
           newPolicyBuckets={[{ key: 'dogs', name: 'Dogs' }]}
           preventNoPreferenceSignups={false}
           onConfirm={onConfirm}
@@ -65,7 +65,7 @@ describe('BucketKeyRemappingModal', () => {
 
     fireEvent.click(getByText('Apply and save event'));
 
-    await waitFor(() => expect(onConfirm).toHaveBeenCalledWith([{ from_key: 'signups', to_key: undefined }]));
+    await waitFor(() => expect(onConfirm).toHaveBeenCalledWith([{ from_bucket_id: '1', to_key: undefined }]));
   });
 
   test('submits the selected destination bucket when one is chosen', async () => {
@@ -75,7 +75,7 @@ describe('BucketKeyRemappingModal', () => {
       wrap(
         <BucketKeyRemappingModal
           visible
-          removedBuckets={[{ key: 'signups', name: 'Cats' }]}
+          removedBuckets={[{ id: '1', key: 'signups', name: 'Cats' }]}
           newPolicyBuckets={[{ key: 'dogs', name: 'Dogs' }]}
           preventNoPreferenceSignups={false}
           onConfirm={onConfirm}
@@ -88,7 +88,7 @@ describe('BucketKeyRemappingModal', () => {
     fireEvent.change(getByRole('combobox', { hidden: true }), { target: { value: 'dogs' } });
     fireEvent.click(getByText('Apply and save event'));
 
-    await waitFor(() => expect(onConfirm).toHaveBeenCalledWith([{ from_key: 'signups', to_key: 'dogs' }]));
+    await waitFor(() => expect(onConfirm).toHaveBeenCalledWith([{ from_bucket_id: '1', to_key: 'dogs' }]));
   });
 
   describe('when the new policy disallows no-preference signups', () => {
@@ -99,7 +99,7 @@ describe('BucketKeyRemappingModal', () => {
         wrap(
           <BucketKeyRemappingModal
             visible
-            removedBuckets={[{ key: 'signups', name: 'Cats' }]}
+            removedBuckets={[{ id: '1', key: 'signups', name: 'Cats' }]}
             newPolicyBuckets={[{ key: 'dogs', name: 'Dogs' }]}
             preventNoPreferenceSignups
             onConfirm={onConfirm}
@@ -121,7 +121,7 @@ describe('BucketKeyRemappingModal', () => {
         wrap(
           <BucketKeyRemappingModal
             visible
-            removedBuckets={[{ key: 'signups', name: 'Cats' }]}
+            removedBuckets={[{ id: '1', key: 'signups', name: 'Cats' }]}
             newPolicyBuckets={[{ key: 'dogs', name: 'Dogs' }]}
             preventNoPreferenceSignups
             onConfirm={onConfirm}
@@ -139,7 +139,7 @@ describe('BucketKeyRemappingModal', () => {
 
       fireEvent.click(getByText('Apply and save event'));
 
-      await waitFor(() => expect(onConfirm).toHaveBeenCalledWith([{ from_key: 'signups', to_key: 'dogs' }]));
+      await waitFor(() => expect(onConfirm).toHaveBeenCalledWith([{ from_bucket_id: '1', to_key: 'dogs' }]));
     });
   });
 });