From 6e8cdca85a8794210c8ea6507958348b519a666c Mon Sep 17 00:00:00 2001 From: pke11y Date: Thu, 28 Oct 2021 15:50:05 +0100 Subject: [PATCH 1/2] Add failing test for IOS banner --- .../compliance/cisco_ios/ios_basic_backup.txt | 8 +++++++- .../compliance/cisco_ios/ios_basic_feature.py | 1 + .../compliance/cisco_ios/ios_basic_intended.txt | 8 +++++++- .../compliance/cisco_ios/ios_basic_received.json | 12 +++++++++++- 4 files changed, 26 insertions(+), 3 deletions(-) diff --git a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt index 7c11962c..54be34fd 100644 --- a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt +++ b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt @@ -8,4 +8,10 @@ access-list 1 permit 10.10.15.15 access-list 1 permit 10.10.20.20 ! ntp server 192.168.0.100 -ntp server 192.168.0.101 \ No newline at end of file +ntp server 192.168.0.101 +! +banner login ^C +****************** + TEST BANNER +****************** +^C diff --git a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_feature.py b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_feature.py index 89d0635f..ef1ecb88 100644 --- a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_feature.py +++ b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_feature.py @@ -2,4 +2,5 @@ {"name": "bgp", "ordered": True, "section": ["router bgp "]}, {"name": "snmp", "ordered": True, "section": ["snmp-server "]}, {"name": "ntp", "ordered": False, "section": ["ntp server "]}, + {"name": "banner", "ordered": True, "section": ["banner "]}, ] diff --git a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_intended.txt b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_intended.txt index c694f63c..0b76de5b 100644 --- a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_intended.txt +++ b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_intended.txt @@ -8,4 +8,10 @@ access-list 1 permit 10.10.15.15 access-list 1 permit 10.10.20.20 ! ntp server 192.168.0.101 -ntp server 192.168.0.100 \ No newline at end of file +ntp server 192.168.0.100 +! +banner login ^ +****************** + TEST BANNER +****************** +^ \ No newline at end of file diff --git a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json index d89ad26c..14379df1 100644 --- a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json +++ b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json @@ -28,5 +28,15 @@ "missing": "", "ordered_compliant": false, "unordered_compliant": true - } + }, + "banner": { + "actual": "banner login ^C\n******************\n TEST BANNER\n******************\n^C", + "cannot_parse": true, + "compliant": true, + "extra": "", + "intended": "banner login ^\n******************\n TEST BANNER\n******************\n^", + "missing": "", + "ordered_compliant": true, + "unordered_compliant": true + } } \ No newline at end of file From 1597cb6055d8c7cb3c562768ba8205d51883b6c2 Mon Sep 17 00:00:00 2001 From: pke11y Date: Thu, 28 Oct 2021 22:32:10 +0100 Subject: [PATCH 2/2] Changed backup to use ^ - as intended --- .../compliance/compliance/cisco_ios/ios_basic_backup.txt | 4 ++-- .../compliance/compliance/cisco_ios/ios_basic_received.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt index 54be34fd..610bf4bb 100644 --- a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt +++ b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_backup.txt @@ -10,8 +10,8 @@ access-list 1 permit 10.10.20.20 ntp server 192.168.0.100 ntp server 192.168.0.101 ! -banner login ^C +banner login ^ ****************** TEST BANNER ****************** -^C +^ diff --git a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json index 14379df1..c8b499f7 100644 --- a/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json +++ b/tests/unit/mock/config/compliance/compliance/cisco_ios/ios_basic_received.json @@ -30,7 +30,7 @@ "unordered_compliant": true }, "banner": { - "actual": "banner login ^C\n******************\n TEST BANNER\n******************\n^C", + "actual": "banner login ^\n******************\n TEST BANNER\n******************\n^", "cannot_parse": true, "compliant": true, "extra": "",