From 22546bee5c321f44e8620ab44ebc9a760847e1c8 Mon Sep 17 00:00:00 2001 From: Jonas Date: Tue, 11 Aug 2026 11:10:42 +0200 Subject: [PATCH] fix(viewer): align content of old version in viewer version comparison The source viewer in the "compare side by side" view in Viewer app doesn't have a menubar, so it needs a margin-top to align both versions vertically. Signed-off-by: Jonas --- playwright/e2e/versions.spec.ts | 5 +++++ src/components/ViewerComponent.vue | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/playwright/e2e/versions.spec.ts b/playwright/e2e/versions.spec.ts index 7b2600578a8..8538b2e4324 100644 --- a/playwright/e2e/versions.spec.ts +++ b/playwright/e2e/versions.spec.ts @@ -64,6 +64,11 @@ test.describe('Versions with distant timestamps', () => { const current = page.locator('.ProseMirror[contenteditable="true"]') await expect(oldVersion.getByRole('heading', { name: 'V1' })).toBeVisible() await expect(current.getByRole('heading', { name: 'V3' })).toBeVisible() + + // Test that version contents are vertically aligned + const oldBox = await oldVersion.getByRole('heading', { name: 'V1' }).boundingBox() + const currentBox = await oldVersion.getByRole('heading', { name: 'V3' }).boundingBox() + expect(Math.abs(oldBox!.y - currentBox!.y)).toBeLessThan(5) }) }) diff --git a/src/components/ViewerComponent.vue b/src/components/ViewerComponent.vue index 2c6b07c574a..5d53d81f68f 100644 --- a/src/components/ViewerComponent.vue +++ b/src/components/ViewerComponent.vue @@ -167,7 +167,12 @@ body .toastify.dialogs { margin-top: calc(45px + var(--default-clickable-area)); } -.viewer[data-handler='text'] .modal-wrapper .modal-container { +.viewer--split .source-viewer .editor__content-wrapper { + // Account for missing menubar for old version in version comparison + margin-top: calc(var(--default-clickable-area) + 2 * var(--default-grid-baseline)); +} + +.viewer[data-handler="text"] .modal-wrapper .modal-container { bottom: 0; }