From b09671a36bdbac0a9a737f54b3aa8c7420daeb34 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Sat, 4 Jul 2026 09:31:06 +0200 Subject: [PATCH] AttributeVersionRequirementHelper: add defaults to bool parameters --- src/Rules/PHPUnit/AttributeVersionRequirementHelper.php | 4 ++-- .../PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php | 2 +- tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php | 2 +- .../PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Rules/PHPUnit/AttributeVersionRequirementHelper.php b/src/Rules/PHPUnit/AttributeVersionRequirementHelper.php index 966c2bf..41bd178 100644 --- a/src/Rules/PHPUnit/AttributeVersionRequirementHelper.php +++ b/src/Rules/PHPUnit/AttributeVersionRequirementHelper.php @@ -43,9 +43,9 @@ final class AttributeVersionRequirementHelper public function __construct( PHPUnitVersion $PHPUnitVersion, - bool $deprecationRulesInstalled, PhpVersion $phpVersion, - bool $bleedingEdge, + bool $deprecationRulesInstalled = false, + bool $bleedingEdge = false, bool $warnAboutIncompleteVersion = true ) { diff --git a/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php b/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php index be34cf5..af76954 100644 --- a/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php +++ b/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php @@ -52,8 +52,8 @@ protected function getRule(): Rule ), new AttributeVersionRequirementHelper( $phpunitVersion, - false, new PhpVersion($this->phpVersion), + false, true, ), ); diff --git a/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php b/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php index 40d0abd..abdf6f0 100644 --- a/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php +++ b/tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php @@ -196,8 +196,8 @@ protected function getRule(): Rule ), new AttributeVersionRequirementHelper( $phpunitVersion, - $this->deprecationRulesInstalled, new PhpVersion($this->phpVersion), + $this->deprecationRulesInstalled, true, $this->warnAboutIncompleteVersion, ), diff --git a/tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php b/tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php index 31814c0..47495fd 100644 --- a/tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php +++ b/tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php @@ -59,8 +59,8 @@ protected function getRule(): Rule return new ClassAttributeRequiresPhpVersionRule( new AttributeVersionRequirementHelper( $phpunitVersion, - false, new PhpVersion($this->phpVersion), + false, true, $this->warnAboutIncompleteVersion, ),