From 80c30d91f7f3617dccc0e8fd9af57c9bf399cd1d Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Fri, 11 Sep 2026 16:34:27 +0000
Subject: [PATCH] fix: correct cross-package hook import, AU date format,
 button aria-label, and bun:test types

- api.ts: import useDebounce (renamed from useThrottle) from @e2e/utils
- date.ts: emit day-first with no leading zero on day (en-AU, d/mm/yyyy)
- Button: expose accessible name for icon-only buttons via aria-label,
  with dev-mode WCAG 2.2 SC 4.1.2 warning when no aria-label is supplied
- tsconfig.json: add bun-types to types so bun:test resolves
- remove stale/misleading BUG comments in DataTable and useDebounce
---
 apps/web/src/lib/api.ts                       | 12 +++------
 packages/ui/src/components/Button/Button.tsx  | 26 ++++++++++++-------
 .../ui/src/components/DataTable/DataTable.tsx | 14 ++++------
 packages/utils/src/format/date.ts             | 26 +++++++++++--------
 packages/utils/src/hooks/useDebounce.ts       |  3 ---
 tsconfig.json                                 |  1 +
 6 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..d9c4314 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..55e076c 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,12 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button has no visible text, so it needs an `aria-label` to expose
+ * an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value). A caller-supplied
+ * `aria-label` is always used verbatim. Only when `iconOnly` is set AND no label
+ * was supplied do we fall back to the generic `"button"` so the attribute is at
+ * least present — that fallback is a last resort, not a substitute for a
+ * descriptive label, so it is accompanied by a dev-mode warning.
  */
 export function Button({
   children,
@@ -34,13 +33,22 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const missingIconOnlyLabel = iconOnly && !ariaLabel
+
+  if (process.env.NODE_ENV !== "production" && missingIconOnlyLabel) {
+    console.warn(
+      "Button: an icon-only button has no visible text, so it must be given a " +
+        'descriptive `aria-label` to expose an accessible name. Falling back to "button", ' +
+        "which gives assistive technology no useful information (WCAG 2.2 SC 4.1.2 Name, Role, Value).",
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={missingIconOnlyLabel ? "button" : ariaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..b622968 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,22 +16,18 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Clicking a sortable column header sorts ascending; clicking the same header
+ * again toggles the direction. `handleSort` is a plain inline function recreated
+ * on every render (no `useCallback`/`useMemo`), so it always closes over the
+ * current `sortDir` and the toggle reads an up-to-date value.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir(sortDir === "asc" ? "desc" : "asc")
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..521c348 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,25 @@
 /**
  * Date formatting utilities.
+ */
+
+/**
+ * Format a date as d/mm/yyyy in Australian (day-first) order, with no leading
+ * zero on the day — e.g. 1/03/2024, 15/06/2024.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `en-AU` cannot produce an unpadded day via options alone: ICU best-fit pattern
+ * matching snaps `day: "numeric"` up to `"2-digit"` (confirmed via
+ * `resolvedOptions()`), and `formatMatcher: "basic"` does not change this. So we
+ * request 2-digit fields for a stable dd/mm/yyyy shape and strip the day's
+ * leading zero. Safe because `en-AU` always orders the day first.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
+    day: "2-digit",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  })
+    .format(date)
+    .replace(/^0/, "")
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/packages/utils/src/hooks/useDebounce.ts b/packages/utils/src/hooks/useDebounce.ts
index 1773a6d..8332c4a 100644
--- a/packages/utils/src/hooks/useDebounce.ts
+++ b/packages/utils/src/hooks/useDebounce.ts
@@ -1,9 +1,6 @@
 /**
  * Debounce a value — returns the value only after it has stopped changing
  * for `delay` milliseconds.
- *
- * NOTE: This hook was recently renamed from `useThrottle` to `useDebounce`.
- * Any code importing `useThrottle` from this package will break.
  */
 import { useState, useEffect } from "react"
 
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]