From f32e877a345f00648a9b94d26af07f7be6c4deec Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Tue, 15 Sep 2026 16:37:02 +0000
Subject: [PATCH] fix: correct en-AU date padding, icon-only button label, and
 renamed hook import

- formatDate builds from Intl.formatToParts so the day is unpadded (en-AU
  was already day-first; the real defect was zero-padding, e.g. 1 Mar 2024
  now renders 1/03/2024 not 01/03/2024)
- Button always exposes an accessible name via aria-label when iconOnly,
  satisfying WCAG 2.2 SC 4.1.2, with a dev-only warning when unlabelled
- apps/web imports the renamed useDebounce hook (was stale useThrottle,
  which never resolved) fixing the TS2305 build error
- tsconfig declares bun-types so bun:test resolves, clearing the remaining
  tsc errors in test files
---
 apps/web/src/lib/api.ts                      | 13 ++-------
 packages/ui/src/components/Button/Button.tsx | 29 ++++++++++++++------
 packages/utils/src/format/date.ts            | 23 ++++++++--------
 tsconfig.json                                |  1 +
 4 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..109ebb7 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under an app-specific name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..8d05c16 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,13 +17,10 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * When `iconOnly` is true the button renders no visible text, so it always
+ * resolves an accessible name (WCAG 2.2 SC 4.1.2) and warns in development if
+ * no explicit `aria-label` was supplied. Text buttons take their accessible
+ * name from their content and get no `aria-label`.
  */
 export function Button({
   children,
@@ -34,13 +31,27 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  // Icon-only buttons render no visible text, so they must always expose an
+  // accessible name (WCAG 2.2 SC 4.1.2). Prefer the explicit aria-label, fall
+  // back to string children, then to a generic label so the button is never
+  // left nameless. Labelled text buttons get their name from their content.
+  const resolvedAriaLabel = iconOnly
+    ? ariaLabel ?? (typeof children === "string" ? children : "Button")
+    : ariaLabel
+
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") {
+    console.warn(
+      "[Button] `iconOnly` requires an explicit `aria-label` for WCAG 2.2 SC 4.1.2. " +
+        "Falling back to a generic label — pass `aria-label` to describe the action.",
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..a933218 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,20 @@
 /**
  * Date formatting utilities.
- *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  // en-AU is day-first, but `day: "numeric"` still zero-pads alongside a numeric
+  // month (1 March -> "01/03/2024"). Build from parts so the day is unpadded while
+  // the month stays 2-digit and the year stays 4-digit: "1/03/2024", "15/06/2024".
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+
+  const get = (type: Intl.DateTimeFormatPartTypes) =>
+    parts.find((p) => p.type === type)?.value ?? ""
+
+  return `${Number(get("day"))}/${get("month")}/${get("year")}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]