From 54d7be1ec8a9d7e8390b882ee9fa61281cdde7cd Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Sun, 20 Sep 2026 16:40:42 +0000 Subject: [PATCH] fix: repair cross-package test failures and type errors - bunfig.toml: replace unrecognised `environment` key with a test preload so the happy-dom DOM globals register for a bare `bun test` - Button: apply an aria-label for icon-only buttons with a dev-only warning when one is omitted (WCAG 2.2 SC 4.1.2) - formatDate: use explicit numeric en-AU fields via formatToParts to render unpadded day-first dates ("1/3/2024") while preserving the 4-digit year - api.ts: useThrottle -> useDebounce at both the import and re-export sites following the hook rename in @e2e/utils - tsconfig: add bun-types (fixes `bun:test` resolution) and typecheck apps/*/test bun test: 13 pass / 0 fail. tsc --noEmit: clean. --- apps/web/src/lib/api.ts | 12 +++------- bunfig.toml | 2 +- packages/ui/src/components/Button/Button.tsx | 23 ++++++++++++------- packages/utils/src/format/date.ts | 24 +++++++++++--------- tsconfig.json | 3 ++- 5 files changed, 34 insertions(+), 30 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..b0121b5 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..1cb73b3 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..297bfdd 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,13 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. + * Icon-only buttons render no visible text, so they must carry an `aria-label` + * to expose an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value). * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Callers should always pass an explicit, meaningful `aria-label` when using + * `iconOnly`. A development-only warning is emitted when it is missing, and a + * generic fallback is applied so the button is never left with no accessible + * name at all. */ export function Button({ children, @@ -34,13 +34,20 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) { + console.warn( + "Button: `iconOnly` buttons require an explicit `aria-label` for an accessible name (WCAG 2.2 SC 4.1.2)." + ) + } + + const resolvedAriaLabel = ariaLabel ?? (iconOnly ? "Button" : undefined) + return (