diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..56c1c04 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app-facing name +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..1cb73b3 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..4039804 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,11 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * An icon-only button renders no visible text, so it must still expose an + * accessible name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). + * When `iconOnly` is set we always emit an `aria-label`: the caller-supplied + * one where given, otherwise a fallback derived from `children`, and we warn + * in development so the missing label gets fixed at the call site. */ export function Button({ children, @@ -34,15 +32,29 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + const resolvedLabel = iconOnly + ? ariaLabel || (typeof children === "string" ? children : "Button") + : ariaLabel + + if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") { + console.warn( + "Button: `iconOnly` buttons require an explicit `aria-label` for screen " + + `reader users (WCAG 4.1.2). Falling back to "${resolvedLabel}".`, + ) + } + return ( ) diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..c9b05d3 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -16,22 +16,20 @@ type Props> = { /** * DataTable with client-side sorting. * - * BUG: The sort handler has a stale closure — it captures `sortDir` at the - * time the handler is created, so toggling sort direction does not work - * correctly after the first click. The second click always sorts in the same - * direction as the first. - * - * Fix: use the functional form of setState — `setSortDir(prev => ...)` — - * so the toggle always reads the current value. + * The sort direction toggle uses the functional form of `setState` so it reads + * the value at the time the update is applied, not the one captured when the + * handler was created. Reading `sortDir` directly also works for one click per + * render — React re-renders between discrete events, so the closure is fresh — + * but it goes stale as soon as multiple updates are queued within a single + * event. The functional form is correct in both cases. */ export function DataTable>({ data, columns }: Props) { const [sortKey, setSortKey] = useState(null) const [sortDir, setSortDir] = useState("asc") - // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir((prev) => (prev === "asc" ? "desc" : "asc")) } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..b04f058 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -1,26 +1,35 @@ /** * Date formatting utilities. * - * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style - * format string option (`month: 'numeric'` before `day: 'numeric'`), which - * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates. + * Australian date convention is d/MM/yyyy — day first and unpadded, with a + * zero-padded month and a four-digit year (e.g. 1/03/2024, 15/06/2024). * - * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly - * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'` - * and rely on the locale to order them correctly. + * Dates are rendered in the host timezone. Callers that need a fixed + * Australian civil date regardless of where the process runs should convert + * before formatting — an instant near midnight UTC lands on a different + * calendar day in eastern Australia. + * + * `formatDate` and `formatDateTime` deliberately share the same date portion, + * so the two never disagree on how a given day is written. */ export function formatDate(date: Date): string { - // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY - return new Intl.DateTimeFormat("en-AU", { - month: "numeric", + const parts = new Intl.DateTimeFormat("en-AU", { day: "numeric", + month: "2-digit", year: "numeric", - }).format(date) + }).formatToParts(date) + + const part = (type: Intl.DateTimeFormatPartTypes): string => + parts.find((p) => p.type === type)?.value ?? "" + + const day = String(Number(part("day"))) + const month = part("month").padStart(2, "0") + + return `${day}/${month}/${part("year")}` } export function formatDateTime(date: Date): string { - return new Intl.DateTimeFormat("en-AU", { - dateStyle: "short", - timeStyle: "short", - }).format(date) + const time = new Intl.DateTimeFormat("en-AU", { timeStyle: "short" }).format(date) + + return `${formatDate(date)}, ${time}` } diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]