diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..ac91c59 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app's domain-specific name +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..0b64f7c 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..fb952ba 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -14,16 +14,23 @@ type Props = { "aria-label"?: string } +const FALLBACK_ICON_LABEL = "Button" + /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. + * An icon-only button has no visible text, so it must carry an `aria-label` to + * expose an accessible name to assistive technology (WCAG 2.2 SC 4.1.2 + * Name, Role, Value). + * + * An explicitly passed `aria-label` is always forwarded, whether or not the + * button is icon-only. A button with visible text derives its accessible name + * from its content by default, so when a caller overrides that name it must + * keep the visible text within the label (WCAG 2.2 SC 2.5.3 Label in Name). * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * If `iconOnly` is set without an `aria-label`, the component falls back to any + * string children and then to a generic label so the button is never left + * unnamed, and warns in development so the omission is caught early. */ export function Button({ children, @@ -34,13 +41,26 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + let accessibleName: string | undefined = ariaLabel?.trim() || undefined + + if (iconOnly) { + const childText = typeof children === "string" ? children.trim() : "" + accessibleName = ariaLabel?.trim() || childText || FALLBACK_ICON_LABEL + + if (process.env.NODE_ENV !== "production" && !ariaLabel?.trim()) { + console.warn( + "[Button] `iconOnly` buttons require an explicit `aria-label` to provide an " + + `accessible name (WCAG 2.2 SC 4.1.2). Falling back to "${accessibleName}".`, + ) + } + } + return (