diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..56c1c04 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
/**
* API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
*/
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +21,5 @@ export async function fetchPosts() {
// Re-export formatting utilities used throughout the app
export { formatDate, formatAUD }
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..0b64f7c 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
[test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..0c508a3 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -14,16 +14,22 @@ type Props = {
"aria-label"?: string
}
+const ICON_ONLY_FALLBACK_LABEL = "Button"
+
/**
* Button component.
*
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
+ * Icon-only buttons render no visible text, so they must expose an accessible
+ * name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). This component
+ * always applies an `aria-label` when `iconOnly` is set:
+ *
+ * 1. the explicit `aria-label` prop, if provided;
+ * 2. otherwise the `children` when they are a plain string;
+ * 3. otherwise a generic fallback, accompanied by a development warning so the
+ * missing label is surfaced to the developer rather than shipped silently.
*
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * For buttons with visible text no `aria-label` is applied, so the visible
+ * label remains the accessible name (WCAG 2.2 SC 2.5.3 Label in Name).
*/
export function Button({
children,
@@ -34,16 +40,29 @@ export function Button({
onClick,
"aria-label": ariaLabel,
}: Props) {
+ let accessibleLabel = ariaLabel
+
+ if (iconOnly && !accessibleLabel) {
+ accessibleLabel = typeof children === "string" && children.trim() ? children.trim() : ICON_ONLY_FALLBACK_LABEL
+
+ if (process.env.NODE_ENV !== "production") {
+ console.warn(
+ "[Button] An icon-only Button was rendered without an `aria-label`. " +
+ `Falling back to "${accessibleLabel}". Pass an explicit \`aria-label\` ` +
+ "describing the action to meet WCAG 2.2 SC 4.1.2.",
+ )
+ }
+ }
+
return (
)
-}
+}
\ No newline at end of file
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..a809b90 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,26 +16,20 @@ type Props> = {
/**
* DataTable with client-side sorting.
*
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Clicking a sortable column header sorts by that column ascending; clicking
+ * the already-active column toggles between ascending and descending. The
+ * toggle uses the functional form of `setState` so it always reads the current
+ * direction rather than a value captured when the handler was created.
*/
export function DataTable>({ data, columns }: Props) {
- const [sortKey, setSortKey] = useState(null)
- const [sortDir, setSortDir] = useState("asc")
+ const [sort, setSort] = useState<{ key: keyof T | null; dir: SortDir }>({ key: null, dir: "asc" })
+ const { key: sortKey, dir: sortDir } = sort
- // BUG: stale closure — sortDir is captured at handler creation time
const handleSort = (key: keyof T) => {
- if (sortKey === key) {
- setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
- } else {
- setSortKey(key)
- setSortDir("asc")
- }
+ setSort((prev) => ({
+ key,
+ dir: prev.key === key && prev.dir === "asc" ? "desc" : "asc",
+ }))
}
const sorted = sortKey
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..efde13c 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,24 @@
/**
* Date formatting utilities.
*
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
+ * `formatDate` produces Australian-style day-before-month dates (e.g. 1/03/2024,
+ * 15/06/2024). The field order and separators come from the `en-AU` locale
+ * rather than from an explicit format string.
*
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Note: ICU's `en-AU` short date pattern zero-pads the day (`dd/MM/y`), which
+ * yields "01/03/2024". We format to parts and emit the day unpadded so the
+ * output matches the conventional en-AU rendering of "1/03/2024".
*/
+const AU_DATE_FORMAT = new Intl.DateTimeFormat("en-AU", {
+ day: "numeric",
+ month: "2-digit",
+ year: "numeric",
+})
+
export function formatDate(date: Date): string {
- // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
- return new Intl.DateTimeFormat("en-AU", {
- month: "numeric",
- day: "numeric",
- year: "numeric",
- }).format(date)
+ return AU_DATE_FORMAT.formatToParts(date)
+ .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value))
+ .join("")
}
export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
"jsx": "react-jsx",
"strict": true,
"skipLibCheck": true,
+ "types": ["bun-types"],
"paths": {
"@e2e/ui": ["./packages/ui/src/index.ts"],
"@e2e/utils": ["./packages/utils/src/index.ts"]