diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..dfe66e4 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app's preferred name +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..0b64f7c 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..8e2c33f 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -14,16 +14,19 @@ type Props = { "aria-label"?: string } +const FALLBACK_ICON_LABEL = "Button" + /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. + * An icon-only button renders no visible text, so it must carry an `aria-label` + * to expose an accessible name to assistive technology (WCAG 2.2 SC 4.1.2 + * Name, Role, Value). When `iconOnly` is set we always emit an `aria-label`: + * the caller's label if provided, otherwise a string child, otherwise a generic + * fallback — and we warn in development so the missing label gets fixed. * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Text buttons deliberately omit `aria-label` so the visible text remains the + * accessible name (WCAG 2.2 SC 2.5.3 Label in Name). */ export function Button({ children, @@ -34,16 +37,28 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + let accessibleLabel = ariaLabel + + if (iconOnly && !accessibleLabel) { + accessibleLabel = typeof children === "string" && children.trim() ? children : FALLBACK_ICON_LABEL + + if (process.env.NODE_ENV !== "production") { + console.warn( + "[Button] An icon-only button requires an explicit `aria-label` to provide an " + + `accessible name (WCAG 2.2 SC 4.1.2). Falling back to "${accessibleLabel}".`, + ) + } + } + return ( ) -} +} \ No newline at end of file diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..d47c5ea 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -16,22 +16,17 @@ type Props> = { /** * DataTable with client-side sorting. * - * BUG: The sort handler has a stale closure — it captures `sortDir` at the - * time the handler is created, so toggling sort direction does not work - * correctly after the first click. The second click always sorts in the same - * direction as the first. - * - * Fix: use the functional form of setState — `setSortDir(prev => ...)` — - * so the toggle always reads the current value. + * Toggling the sort direction uses the functional form of setState so the + * update is derived from the current value rather than the `sortDir` captured + * in the handler's closure at render time. */ export function DataTable>({ data, columns }: Props) { const [sortKey, setSortKey] = useState(null) const [sortDir, setSortDir] = useState("asc") - // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir((prev) => (prev === "asc" ? "desc" : "asc")) } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..0f5889f 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -1,21 +1,22 @@ /** * Date formatting utilities. * - * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style - * format string option (`month: 'numeric'` before `day: 'numeric'`), which - * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates. - * - * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly - * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'` - * and rely on the locale to order them correctly. + * Australian date format is day-first (D/MM/YYYY). The `en-AU` locale orders + * the fields correctly on its own, but it resolves `day` to `2-digit` even when + * `numeric` is requested, which yields a leading zero ("01/03/2024"). Building + * the output from `formatToParts` preserves the locale's field ordering and + * separators while emitting the day without a leading zero ("1/03/2024"). */ export function formatDate(date: Date): string { - // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY - return new Intl.DateTimeFormat("en-AU", { - month: "numeric", + const parts = new Intl.DateTimeFormat("en-AU", { day: "numeric", + month: "2-digit", year: "numeric", - }).format(date) + }).formatToParts(date) + + return parts + .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value)) + .join("") } export function formatDateTime(date: Date): string { diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]