From 7cd361533a0a576273b737ca3d5cf65a49f03ab3 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Wed, 30 Sep 2026 16:46:43 +0000
Subject: [PATCH] fix: resolve cross-package test and type failures

- apps/web: import renamed useDebounce hook (was useThrottle)
- ui/Button: ensure icon-only buttons get an aria-label
- ui/DataTable: use functional state update to fix stale closure in sort toggle
- utils/formatDate: en-AU day-first format without leading zero on day
- bunfig.toml: preload happy-dom global registrator so DOM tests run
- tsconfig: include bun-types so bun:test resolves
---
 apps/web/src/lib/api.ts                       | 13 ++-----
 bunfig.toml                                   |  2 +-
 packages/ui/src/components/Button/Button.tsx  | 29 ++++++++++-----
 .../ui/src/components/DataTable/DataTable.tsx | 12 ++-----
 packages/utils/src/format/date.ts             | 35 ++++++++++---------
 tsconfig.json                                 |  6 ++++
 6 files changed, 52 insertions(+), 45 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..56c1c04 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..1cb73b3 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
\ No newline at end of file
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..aa87862 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -14,16 +14,15 @@ type Props = {
   "aria-label"?: string
 }
 
+const ICON_ONLY_FALLBACK_LABEL = "Button"
+
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button has no visible text, so it must expose an accessible name
+ * via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). When `iconOnly` is set
+ * without an `aria-label`, we fall back to string children (if any) so the button
+ * is never nameless, and warn in development so the missing label gets fixed.
  */
 export function Button({
   children,
@@ -34,13 +33,25 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  let accessibleLabel = ariaLabel
+
+  if (iconOnly && !accessibleLabel) {
+    accessibleLabel = typeof children === "string" ? children : ICON_ONLY_FALLBACK_LABEL
+
+    if (process.env.NODE_ENV !== "production") {
+      console.warn(
+        "Button: `iconOnly` buttons have no visible text and require an explicit " +
+          `\`aria-label\` for screen reader users (WCAG 2.2 SC 4.1.2). Falling back to "${accessibleLabel}".`,
+      )
+    }
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..b068bb0 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,22 +16,16 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Sort direction is toggled with the functional form of setState so the handler
+ * always reads the current direction rather than the value captured in its closure.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..272f94b 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,26 +1,29 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
+ * Australian date format is day-first with an unpadded day and a zero-padded
+ * month: D/MM/YYYY (e.g. 1/03/2024, 15/06/2024).
  *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `en-AU` already orders the fields day-first, but it pads the day to two digits
+ * even when `day: "numeric"` is requested. We rebuild the string from the parts
+ * so the day is unpadded while keeping the locale's own separators.
  */
+const AU_DATE_FORMAT = new Intl.DateTimeFormat("en-AU", {
+  day: "numeric",
+  month: "2-digit",
+  year: "numeric",
+})
+
+const AU_TIME_FORMAT = new Intl.DateTimeFormat("en-AU", {
+  timeStyle: "short",
+})
+
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  return AU_DATE_FORMAT.formatToParts(date)
+    .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {
-  return new Intl.DateTimeFormat("en-AU", {
-    dateStyle: "short",
-    timeStyle: "short",
-  }).format(date)
+  return `${formatDate(date)}, ${AU_TIME_FORMAT.format(date)}`
 }
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..013737a 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,12 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    // Required for the `bun:test` module declaration the test files import.
+    // Note this also narrows ambient type inclusion to bun-types alone — any
+    // future @types package that is ambient-only (i.e. not reached via an
+    // import) must be added here explicitly. `@types/react` is unaffected
+    // because it resolves through `import React from "react"`.
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]