Skip to content

feat: Include aliases toBeSameAs and toBe for toBeSame#109

Merged
JoseLion merged 3 commits into
mainfrom
fix/solve-issue-108
Oct 31, 2023
Merged

feat: Include aliases toBeSameAs and toBe for toBeSame#109
JoseLion merged 3 commits into
mainfrom
fix/solve-issue-108

Conversation

@CristhianMotoche

@CristhianMotoche CristhianMotoche commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Changes

Include toBeSameAs and toBe alias for toBeSame.

NOTE: My code formatter modified some files. Let me know if it's okay to keep it that way, otherwise I can revert that to keep only the necessary changes.

Solves #108


As part of Stack Builders Inc. Hacktoberfest 2023 event.

});
});

describe(".toBeSameAs", () => {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes that matter in this file for this PR.

});
}

/**

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes that matter in this file for this PR.

@JoseLion JoseLion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relevant changes look great! Do you think we can revert the formatter changes, though? 🙂

@CristhianMotoche

Copy link
Copy Markdown
Contributor Author

Hi @JoseLion I reverted the code formatter changes. Let me know if looks better now.

@JoseLion JoseLion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your contribution @CristhianMotoche 🎉

@JoseLion
JoseLion merged commit c7a061a into main Oct 31, 2023
@JoseLion
JoseLion deleted the fix/solve-issue-108 branch October 31, 2023 21:14
@JoseLion JoseLion added the hacktoberfest-accepted PRs accepted during Hacktoberfest label Oct 31, 2023
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PRs accepted during Hacktoberfest released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants