From 8220cbe3acb889403525a8eff904dbe2927628b8 Mon Sep 17 00:00:00 2001 From: Reynier Ortiz Vega Date: Tue, 30 Jun 2026 18:06:50 -0400 Subject: [PATCH] Fix stale pre-pulled image tag causing flaky E2E timeouts The osv-mcp pre-pull step in CI pulled tag 0.1.0, but the "osv" registry entry these tests actually use resolves to 0.1.3. The mismatch forced a cold pull mid-test, intermittently eating into the tight 60s readiness timeout and causing api-clients/api-misc E2E jobs to fail and require a re-run (#5690). Bump the pre-pull tag to match, and add modest timeout headroom to the two affected tests for resilience against transient pull or runner slowness. --- .github/workflows/e2e-tests.yml | 2 +- test/e2e/api_clients_validation_test.go | 4 ++-- test/e2e/api_groups_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 0b0689470c..4bfef44909 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -123,7 +123,7 @@ jobs: run: | # Pre-pull images used by E2E tests so that workload creation # does not pay the image-pull cost inside the 60s API timeout. - docker pull ghcr.io/stackloklabs/osv-mcp/server:0.1.0 & + docker pull ghcr.io/stackloklabs/osv-mcp/server:0.1.3 & docker pull ghcr.io/stackloklabs/gofetch/server:1.0.2 & docker pull ghcr.io/stacklok/toolhive/egress-proxy:latest & # yardstick is only needed for the vmcp test suite diff --git a/test/e2e/api_clients_validation_test.go b/test/e2e/api_clients_validation_test.go index fb15953a74..608ab73c5e 100644 --- a/test/e2e/api_clients_validation_test.go +++ b/test/e2e/api_clients_validation_test.go @@ -53,7 +53,7 @@ var _ = Describe("Clients API Validation", Label("api", "api-clients", "clients" } } return false - }, 60*time.Second, 2*time.Second).Should(BeTrue()) + }, 90*time.Second, 2*time.Second).Should(BeTrue()) By("Attempting to register with an invalid client type") invalidClientName := fmt.Sprintf("invalid-client-%d", time.Now().UnixNano()) @@ -115,7 +115,7 @@ var _ = Describe("Clients API Validation", Label("api", "api-clients", "clients" } } return false - }, 60*time.Second, 2*time.Second).Should(BeTrue()) + }, 90*time.Second, 2*time.Second).Should(BeTrue()) By("Attempting bulk register with invalid client types") invalidClientName1 := fmt.Sprintf("invalid-bulk-1-%d", time.Now().UnixNano()) diff --git a/test/e2e/api_groups_test.go b/test/e2e/api_groups_test.go index 4d2dbee51c..e7e9c4331b 100644 --- a/test/e2e/api_groups_test.go +++ b/test/e2e/api_groups_test.go @@ -357,7 +357,7 @@ var _ = Describe("Groups API", Label("api", "api-misc", "groups", "e2e"), func() } } return false - }, 60*time.Second, 2*time.Second).Should(BeTrue(), + }, 90*time.Second, 2*time.Second).Should(BeTrue(), "Workload should reach running state before deletion") By("Deleting the group with workloads")