From 8300561eeab7fbb2b1c88147bb06b75aa90b54d8 Mon Sep 17 00:00:00 2001 From: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com> Date: Mon, 10 Aug 2026 18:33:16 +0100 Subject: [PATCH] Stop writing the PR number into the size artifact Nothing reads it now: the apply workflow derives the number from its own workflow_run event. The write was kept only so the consumer still on the default branch, which did read it, would keep working until that change landed. It has, so the artifact carries the label alone. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/pr-size-labeler.yml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pr-size-labeler.yml b/.github/workflows/pr-size-labeler.yml index 56e97d0902..0e898acb7f 100644 --- a/.github/workflows/pr-size-labeler.yml +++ b/.github/workflows/pr-size-labeler.yml @@ -65,21 +65,14 @@ jobs: # This workflow runs on `pull_request`, so a pull request — including one # from a fork — supplies the definition that produces these files. # Nothing in them can be trusted to say which pull request to act on, so - # the consumer derives the number from its own trigger event instead. - # - # pr-number.txt is still written even though the new consumer ignores it. - # `workflow_run` consumers always execute the copy on the default branch, - # so until this change merges the consumer reading it is the old one, and - # dropping the file here would break labelling for every open pull - # request. Removing the write is a follow-up once this has landed. + # the consumer derives the number from its own trigger event instead, so + # the label is the only thing that needs to cross the boundary. - name: Save size label to artifact env: SIZE_LABEL: ${{ steps.size.outputs.result }} - PR_NUMBER: ${{ github.event.pull_request.number }} run: | mkdir -p pr-size echo "$SIZE_LABEL" > pr-size/label.txt - echo "$PR_NUMBER" > pr-size/pr-number.txt - name: Upload artifact uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6