From a7d74827d0da4d7f1e07a525f9098e17de9ad6f0 Mon Sep 17 00:00:00 2001 From: thawk105 Date: Wed, 13 May 2026 15:47:40 +0000 Subject: [PATCH 1/2] Phase 2: enable -Werror=ignored-qualifiers (cmake side) --- cmake/ProtocolHelpers.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmake/ProtocolHelpers.cmake b/cmake/ProtocolHelpers.cmake index 40617262..85e27741 100644 --- a/cmake/ProtocolHelpers.cmake +++ b/cmake/ProtocolHelpers.cmake @@ -54,7 +54,8 @@ function(ccbench_add_protocol name) -Werror=reorder -Werror=unused-parameter -Werror=catch-value - -Werror=unused-variable) + -Werror=unused-variable + -Werror=ignored-qualifiers) set_property(TARGET ${target} PROPERTY CCBENCH_PROTOCOL "${name}") set_property(TARGET ${target} PROPERTY CCBENCH_WORKLOAD "${wl}") From 7874311580e06efc23a99a18eea247a052fc54da Mon Sep 17 00:00:00 2001 From: thawk105 Date: Wed, 13 May 2026 15:53:36 +0000 Subject: [PATCH 2/2] Phase 2: fix ignored-qualifiers in bomb workload headers The three static helpers `get_i_id_product_start/material_start/work_start` return `uint32_t` by value, but were declared with a top-level `const` on the return type. GCC's `-Wignored-qualifiers` flags this as a no-op qualifier (a value-returned `const uint32_t` is no different from `uint32_t` to the caller). Drop the redundant `const` from the return type in both bomb.hh and bomb_pessimistic.hh. --- include/bomb.hh | 6 +++--- include/bomb_pessimistic.hh | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/bomb.hh b/include/bomb.hh index e7247a17..3c82bcd6 100644 --- a/include/bomb.hh +++ b/include/bomb.hh @@ -503,15 +503,15 @@ public: } }; - static const uint32_t get_i_id_product_start() { + static uint32_t get_i_id_product_start() { return 1; } - static const uint32_t get_i_id_material_start() { + static uint32_t get_i_id_material_start() { return get_i_id_product_start() + FLAGS_bomb_product_size; } - static const uint32_t get_i_id_work_start() { + static uint32_t get_i_id_work_start() { return get_i_id_material_start() + FLAGS_bomb_material_size; } diff --git a/include/bomb_pessimistic.hh b/include/bomb_pessimistic.hh index f2983414..3fcdcd87 100644 --- a/include/bomb_pessimistic.hh +++ b/include/bomb_pessimistic.hh @@ -537,15 +537,15 @@ public: } }; - static const uint32_t get_i_id_product_start() { + static uint32_t get_i_id_product_start() { return 1; } - static const uint32_t get_i_id_material_start() { + static uint32_t get_i_id_material_start() { return get_i_id_product_start() + FLAGS_bomb_product_size; } - static const uint32_t get_i_id_work_start() { + static uint32_t get_i_id_work_start() { return get_i_id_material_start() + FLAGS_bomb_material_size; }