fix(core): page creation should respect page options (#1673)

Author: Mister-Hope

packages/core/src/page/createPage.ts

@@ -60,7 +60,11 @@ export const createPage = async (
   const date = resolvePageDate({ frontmatter, filePathRelative })
 
   // infer page path according to file path
-  const { pathInferred, pathLocale } = inferPagePath({ app, filePathRelative })
+  const { pathInferred, pathLocale } = inferPagePath({
+    app,
+    filePathRelative,
+    options,
+  })
 
   // resolve language from frontmatter and site options
   const lang = resolvePageLang({ app, frontmatter, pathLocale })

packages/core/src/page/inferPagePath.ts

@@ -3,7 +3,7 @@ import {
   inferRoutePath,
   resolveLocalePath,
 } from '@vuepress/shared'
-import type { App } from '../types/index.js'
+import type { App, PageOptions } from '../types/index.js'
 
 /**
  * Infer page path according to file path
@@ -13,13 +13,27 @@ import type { App } from '../types/index.js'
 export const inferPagePath = ({
   app,
   filePathRelative,
+  options,
 }: {
   app: App
   filePathRelative: string | null
+  options: PageOptions
 }): {
   pathInferred: string | null
   pathLocale: string
 } => {
+  // user has explicitly set path in options
+  if (options.path) {
+    const pathLocale = resolveLocalePath(app.siteData.locales, options.path)
+
+    return {
+      pathInferred: filePathRelative
+        ? inferRoutePath(ensureLeadingSlash(filePathRelative))
+        : null,
+      pathLocale,
+    }
+  }
+
   if (!filePathRelative) {
     return {
       pathInferred: null,

packages/core/tests/page/createPage.spec.ts

@@ -5,6 +5,14 @@ import { createBaseApp, createPage } from '../../src/index.js'
 
 describe('should work without plugins', () => {
   const app = createBaseApp({
+    locales: {
+      '/': {
+        lang: 'en-US',
+      },
+      '/zh/': {
+        lang: 'zh-CN',
+      },
+    },
     source: path.resolve(__dirname, 'fake-source'),
     theme: { name: 'test' },
     bundler: {} as Bundler,
@@ -86,6 +94,37 @@ describe('should work without plugins', () => {
     )
     expect(page.chunkName).toBeTruthy()
   })
+
+  it('should create a zh page', async () => {
+    const page = await createPage(app, {
+      path: '/zh/test.html',
+    })
+
+    // page data
+    expect(page.data.path).toBe('/zh/test.html')
+    expect(page.data.lang).toBe('zh-CN')
+
+    // base fields
+    expect(page.path).toBe('/zh/test.html')
+    expect(page.lang).toBe('zh-CN')
+
+    // file info
+    expect(page.htmlFilePath).toBe(app.dir.dest(`zh/test.html`))
+    expect(page.htmlFilePathRelative).toBe(`zh/test.html`)
+    expect(page.componentFilePath).toBe(
+      app.dir.temp(`pages/${page.htmlFilePathRelative}.vue`),
+    )
+    expect(page.componentFilePathRelative).toBe(
+      `pages/${page.htmlFilePathRelative}.vue`,
+    )
+    expect(page.chunkFilePath).toBe(
+      app.dir.temp(`pages/${page.htmlFilePathRelative}.js`),
+    )
+    expect(page.chunkFilePathRelative).toBe(
+      `pages/${page.htmlFilePathRelative}.js`,
+    )
+    expect(page.chunkName).toBeTruthy()
+  })
 })
 
 describe('should work with plugins', () => {

packages/core/tests/page/inferPagePath.spec.ts

@@ -86,6 +86,7 @@ describe('should infer page path according to relative path of page file', () =>
         inferPagePath({
           app,
           filePathRelative: source,
+          options: {},
         }),
       ).toEqual(expected)
     })
@@ -97,6 +98,7 @@ it('should use `/` as the default locale path', () => {
     inferPagePath({
       app: appWithoutLocales,
       filePathRelative: 'en/foo/bar.md',
+      options: {},
     }),
   ).toEqual({
     pathInferred: '/en/foo/bar.html',
@@ -109,9 +111,34 @@ it('should handle empty file relative path', () => {
     inferPagePath({
       app,
       filePathRelative: null,
+      options: {},
     }),
   ).toEqual({
     pathInferred: null,
     pathLocale: '/',
   })
 })
+
+it('should respect options.path', () => {
+  expect(
+    inferPagePath({
+      app,
+      filePathRelative: 'foo/bar.md',
+      options: { path: '/custom/path.html' },
+    }),
+  ).toEqual({
+    pathInferred: '/foo/bar.html',
+    pathLocale: '/',
+  })
+
+  expect(
+    inferPagePath({
+      app,
+      filePathRelative: 'zh/foo/bar.md',
+      options: { path: '/zh/custom/path.html' },
+    }),
+  ).toEqual({
+    pathInferred: '/zh/foo/bar.html',
+    pathLocale: '/zh/',
+  })
+})