Repository navigation
feat(distribution): add Windows PowerShell installer - #257
Merged
Merged
Conversation
Teakowa
requested changes
Sep 4, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Major — install.ps1 installs by default into %LOCALAPPDATA%\Programs\Wright\bin, but it neither adds that directory to PATH nor tells the user how to make wright available by name. A clean user following the documented one-liner therefore gets a successful install but cannot invoke wright normally afterward. This misses the first-party installer/PATH-handling contract inherited from #108/#254. Add explicit PATH handling or an actionable post-install PATH instruction (at minimum matching install.sh).
Teakowa
enabled auto-merge (squash)
September 4, 2026 16:49
Resolve the merge after #253 and retain the Windows installer changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.ps1for latest or pinned releaseswright.exeandwright-lsp.exeVerification
python3 scripts/verify-dist.pyshellcheck install.shgit diff --checkYAML.load_filewindows-latestbut was not runnable on this macOS hostFixes #254