UI polish + testing setup (Vitest / Playwright + CI) - #123
Merged
Merged
Conversation
- Landing page: turn the bare page into a proper hero with an eyebrow badge, themed gradient headline, CTA buttons (Get Started / GitHub) and a soft background glow; switch hardcoded gray colors to semantic tokens - Fix the headline spacing bug where "Let's Start" and "Together" rendered with no space between them - Header: add a translucent background + bottom border so it separates from content when scrolling, and convert the raw clickable icons into accessible ghost icon buttons (aria-labels, hover/focus states) - SignIn trigger restyled to match the header icon buttons - Footer: use theme tokens, add a copyright line and a top border - 404: centered layout with a large gradient code, proper spacing - Add reusable GithubIcon (lucide 1.x dropped the brand icon) - Add home.cta i18n key to both locales (parity preserved) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017oJ9xs9iSZN3ahQ6hKsh3u
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Completes the README "Testing" TODO. - Vitest + Testing Library + jsdom via a standalone vitest.config.ts (so the app-only Vite plugins don't run during tests); example unit tests for cn() and the Button component - Playwright config + a language-agnostic home-page E2E spec - GitHub Actions: new test.yml runs type-check, lint and unit tests, plus a Playwright E2E job, on push and pull_request; main.yml now also runs on pull_request - README: move testing from TODO into Features, document pnpm test / pnpm test:e2e, bump the React 18 reference to 19 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017oJ9xs9iSZN3ahQ6hKsh3u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
앱 핵심 화면 UI를 다듬고, README의 남은 TODO(테스트 구성)를 마저 처리했습니다. 두 가지 작업이 한 브랜치(
claude/keen-euler-uhuaho)에 함께 담겨 있습니다.1) UI 개선
핵심 화면(랜딩 · 헤더 · 푸터 · 404)을 디자인 시스템(shadcn 시맨틱 토큰)에 맞춰 다듬고 시각적 버그도 수정했습니다. (
/example쇼케이스는 이미 잘 구성되어 그대로 둠)text-gray-*→ 시맨틱 토큰"Let's Start"+"Together"가 공백 없이 붙던 헤드라인 띄어쓰기 수정before:장식 제거Github대체용GithubIcon추가,home.ctai18n 키 en/ko 동시 추가(parity 유지)2) 테스트 구성 (README TODO 완료)
vitest.config.ts사용. 예제 단위 테스트(cn(),Button) 포함 → 7개 통과test.yml신설 —push/pull_request에서 type-check · lint · 단위 테스트 + Playwright E2E 잡 실행. 기존main.yml도pull_request에서 빌드하도록 트리거 추가pnpm test/pnpm test:e2e문서화, React 18 표기 → 19검증
pnpm buildpnpm tscpnpm lintpnpm test(Vitest)pnpm test:e2e(Playwright)cdn.playwright.dev차단되어 브라우저 다운로드 불가(--list로 스펙 유효성은 확인)🤖 Generated with Claude Code
https://claude.ai/code/session_017oJ9xs9iSZN3ahQ6hKsh3u