Use shell functions instead of aliases to avoid interfering with shell completion

[jimeh]

op CLI version

2.24.0

Goal or desired behavior

I want to setup the homebrew shell plugin (as an example), and have shell completion work correctly for brew, and also my custom shell alias (alias br=brew).

This can be achieved by using a shell function in ~/.config/op/plugins.sh instead of an alias:

brew() { op plugin run -- brew "$@"; }

Current behavior

Currently when you run op plugin init brew, a shell alias is written to ~/.config/op/plugins.sh, for example:

alias brew="op plugin run -- brew"

This results in the brew command no longer having shell completions available on it, unless setopt completealiases is used. But that breaks completion for shorthand aliases like alias br=brew, because it will try to find completions for a command named br.

Hence the shell function approach is the only one that works correctly in both scenarios.

Relevant log output

No response

[mrclrchtr]

Thank you so much for sharing the workaround!

[mrjones2014]

Note for myself: we'll also need to make this change in ./nix/shell-plugins.nix. In a Nix environment, the aliases and managed by Nix instead of by the 1Password CLI.

[mrjones2014]

I started playing around with this idea and ran into a small snag -- it's easy to do in the Nix Flake way of configuring things, because we can just generate separate versions of the shell code.

However, for users not using Nix and having the CLI manage their plugins.sh file, we run into a bit of an issue with Fish shell users, because Fish uses a different function syntax.

Bash/Zsh:

my-func() {
  echo "stuff"
}

Fish:

function my-func
  echo "stuff
end

I'm not sure the best way to approach this with the CLI.

[jimeh]

Simplest approach I guess would to also write out a plugin.fish file, and just update instructions for fish users to load that file instead.

Another approach could be to have a plugin.bash file for bash/zsh and plugin.fish for fish. Then have the existing plugin.sh load one of the files conditionally based on the value of $SHELL. Assuming such a conditional can be written in a bash and fish compatible way.

[jimeh]

In the meantime, I've made my own hacky but automated solution in my dotfiles:

https://github.com/jimeh/dotfiles/blob/f30c675f3b5cebd6a0b58be3905425e50d1b4ba3/zsh/1password.zsh

Why? Because automating stuff is what we do right? Even if said automation might be horrible 😱... Hence, I don't suggest anyone uses my hacky solution, but if you fully understand how it works, and you're still ok with it, feel free to steal it... lol

It basically loads the plugins.sh file as is with aliases, and then finds all aliases which call op plugin run --, replacing them with relevant functions. The shell source that does the replacement is written to a cache file as well which is only updated when needed, ensuring shell startup times aren't slowed down.

[punk-dev-robot]

Hi, I also recently stumbled upon this issue. This is a clever solution but unfortunately, it doesn't work for some completions I use.

It looks like it's popular for completions to include that snippet of code (example from glab - which is gitlab cli tool.

# don't run the completion function when being source-ed or eval-ed
if [ "$funcstack[1]" = "_glab" ]; then
    _glab
fi

I think when we use the function method described here it changes the location of glab on funcstack?

[punk-dev-robot]

I don't have much experience in zsh scripting but the solution that reliably works for me atm is #122 (comment)

[scottisloud]

Hi everyone,

Thanks for the ongoing feedback. We're working on a fix in the 1Password CLI now. We don't have a release timeline to share yet but I'll follow up here once we have a clearer picture of when it will ship.