Conversation
fixes issue 1dot13#498 where retreating from combat in a sector that has a merc inbound via the airdrop marker causes combat not to end the reason this fails is that a the inbound soldier counts as being in the sector being retreated from, even though he isn't I add a check for `MercPtrs[i]->bInSector` so this doesn't happen that way the function doesn't leave early and CheckForEndOfCombatMode is reached
majcosta
deleted the
pr_fix_combat_not_ending_if_merc_is_inbound_retreated_sector
branch
September 12, 2025 01:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #498 where retreating from combat in a sector that has a merc inbound via the airdrop marker causes combat not to end
the reason this fails is that a the inbound soldier counts as being in the sector being retreated from, even though he isn't
I add a check for
MercPtrs[i]->bInSectorso this doesn't happenthat way the function doesn't leave early and CheckForEndOfCombatMode is reached