-
Notifications
You must be signed in to change notification settings - Fork 38
Add Ja2Export target and get it to build on C++17 #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| option(BUILD_JA2EXPORT "Build the Ja2Export tool." ON) | ||
|
|
||
| if(BUILD_JA2EXPORT) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (I dont know best practices)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like having the exporter tool decide whether to |
||
| message(STATUS "Configuring Ja2Export") | ||
|
|
||
| add_executable(Ja2Export | ||
| init_vfs.cpp | ||
| main.cpp | ||
| progress_bar.cpp | ||
| ja2/himage.cpp | ||
| ja2/XMLWriter.cpp | ||
| export/jsd/export_jsd.cpp | ||
| export/jsd/structure.cpp | ||
| export/slf/export_slf.cpp | ||
| export/sti/export_sti.cpp | ||
| export/sti/Image.cpp | ||
| export/sti/stci_image_utils.cpp | ||
| export/sti/STCI_lib.cpp | ||
| ) | ||
| target_include_directories(Ja2Export PUBLIC | ||
| "${CMAKE_CURRENT_SOURCE_DIR}" | ||
| ) | ||
| target_link_libraries(Ja2Export PUBLIC bfVFS libpng) | ||
| set_target_properties(Ja2Export PROPERTIES | ||
| RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR} | ||
| ) | ||
| else() | ||
| message(STATUS "BUILD_JA2EXPORT set to \"OFF\", not configuring Ja2Export by default") | ||
| endif() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean its by default built?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes