Skip to content

Guestacc - #33

Merged
zackman0010 merged 19 commits into
3RaGaming:beta-authfrom
erkkki:guestacc
Feb 6, 2017
Merged

Guestacc#33
zackman0010 merged 19 commits into
3RaGaming:beta-authfrom
erkkki:guestacc

Conversation

@erkkki

@erkkki erkkki commented Feb 2, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@stuudmuffin stuudmuffin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging the new auth code, I updated the beta-auth branch from the master so it would match.

I'm unsure if anything in this pull request is new or different from the master. git handles file changes from different branches into master fairly well. So merges from one branch to another, unless specifically testing a variation of code, is not really needed.

@zackman0010
zackman0010 changed the base branch from beta-auth to master February 2, 2017 18:56
@zackman0010
zackman0010 dismissed stuudmuffin’s stale review February 2, 2017 18:58

I have changed the base from beta-auth to master. I told him to merge into beta-auth because this work is working on making a viable guest page, one without any of the server control functions and view only access. I wanted to link this into Discord Auth so that we didn't just kill if a user wasn't a Mod or Admin.

@erkkki

erkkki commented Feb 2, 2017

Copy link
Copy Markdown
Contributor Author

ah.. merge conflict is because altlogin.php is now old login.php, I think.

@zackman0010

Copy link
Copy Markdown
Contributor

Can you confirm that your changes to the code still work with the base changed?

@erkkki

erkkki commented Feb 2, 2017

Copy link
Copy Markdown
Contributor Author

Done.

@erkkki

erkkki commented Feb 2, 2017

Copy link
Copy Markdown
Contributor Author

I mean altlogin is working.. Can't test auth login and user level things there. But no more conflicts.

@zackman0010

Copy link
Copy Markdown
Contributor

@stuudmuffin Want to go ahead and merge this?

@zackman0010
zackman0010 changed the base branch from master to beta-auth February 6, 2017 02:48
@zackman0010

Copy link
Copy Markdown
Contributor

Changing it back to beta-auth and merging it. I'm gonna test and make sure it all works in production before I merge back into master.

@zackman0010
zackman0010 merged commit 48d5b63 into 3RaGaming:beta-auth Feb 6, 2017
This was referenced Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants