Repository navigation
Today.Storayboard 구현(1) - #20
Merged
Merged
Conversation
dev-jko
reviewed
Apr 27, 2020
dev-jko
self-requested a review
April 27, 2020 12:10
dev-jko
requested changes
Apr 27, 2020
dev-jko
left a comment
Contributor
There was a problem hiding this comment.
OneDayOneAnswer/OneDayOneAnswer/TodayViewController.swift 에서
32번~36번 줄을 textViewAnswer를 불러오는 메서드로 묶는건 어떨까요?
지금은 텍스트뷰 하나지만 다른 요소들이 추가되면 viewDidLoad 메서드가 너무 복잡할 것 같아서요
Member
Author
|
좋은 의견 감사합니다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today.Storayboard 구현 (#10) 관련
금일 작업분 코드리뷰 요청드립니다
0. 추가한 객체
labelDate: 오늘날짜 표시textViewAnswer: 답변 작성할 칸labelPlaceHolder: 답변 작성할 칸에 띄워둘 placeholder(hint)1. 작성날짜(오늘날짜) 표시하기
2. placeholder 만들기
labelPlaceHolderisEmpty와isHidden을 이용하여 작성한 내용이 없으면 답변작성가이드 띄우고 작성한 내용이 있으면 답변작성가이드 없앰3. 답변작성 텍스트뷰 외 누르면 키보드 띄우기
4. 텍스트뷰 외 터치 시 키보드 감추기
5. 기타
xcrun simctl io booted recordVideo ~/simulator.movconvert mov to gif