Feature/list, todayViewController에 모달추가 - #55
Merged
Merged
Conversation
Member
|
아니........ 오늘 회의 마친지 3시간도 안지났는데............?????????? 😮 |
Member
|
사진 선택 너무 잘됩니다...감동입니다... |
365kim
requested changes
May 6, 2020
365kim
left a comment
Member
There was a problem hiding this comment.
리스트뷰로 넘어왔는데 모서리가 잘리는 문제가 있어요!
확인부탁드릴게요~~
365kim
approved these changes
May 6, 2020
| func imagePickerController(_ picker: UIImagePickerController, didFinishPickingMediaWithInfo info: [UIImagePickerController.InfoKey : Any]) { | ||
| if let pickedImage = info[UIImagePickerController.InfoKey.originalImage] as? UIImage { | ||
| backgroundImage.contentMode = .scaleAspectFill | ||
| backgroundImage.contentMode = .scaleToFill |
Member
There was a problem hiding this comment.
.scaleToFill은 이미지 가로세로 비율이 유지되지 않아서
.scaleAspectFill 로 채우는게 더 예쁠것같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
금일 작업분 코드리뷰 요청드립니다.