Feat/fshsp 95 deploy pages - #36
Merged
Merged
Conversation
…ybook Storybook stays at /starter-angular/, the demo lands on /starter-angular/demo/. Both builds are merged into one directory before upload-pages-artifact, Pages accepting a single artifact. GitHub Pages honours exactly one 404.html, the one at the site root, so it has to serve both surfaces: it is the demo's SPA shell, guarded by an inline redirect that sends anything outside /demo/ back to the Storybook home. Two fixes the deployment made necessary: - `npm run build` failed on main: ui-motion.demo.ts passed null to `motionDuration` (`input<string>()`). Only the AOT build catches it — the PR workflow type-checks with `tsc --noEmit`, which ignores Angular templates, and no workflow ran `npm run build` until now. - The favicon was declared before <base> and reached above the deployment sub-path (`../assets/favicon.png`), so it resolved outside /demo/. Cross-links both ways: a topbar entry in the demo, a section on the Storybook home page. (cherry picked from commit 3bbe93f684fdabd801c5aecfae78fb17724b7adc)
LBU4SH
force-pushed
the
feat/fshsp-95-deploy-pages
branch
from
August 14, 2026 14:06
72b9747 to
2470731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FSHSP-95 — Deploy the demo app to GitHub Pages alongside Storybook