Skip to content

fix trajectory dataset type - #28

Merged
hsballoon merged 2 commits into
AI45Lab:v2from
hsballoon:temporaryFixDatasettype
Jul 30, 2026
Merged

fix trajectory dataset type#28
hsballoon merged 2 commits into
AI45Lab:v2from
hsballoon:temporaryFixDatasettype

Conversation

@hsballoon

@hsballoon hsballoon commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Updated cloud dataset handling to consistently use the RL dataset type.
    • Ensured newly created records and training-data queries use the same dataset classification, improving data retrieval consistency.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a9d22998-160c-464c-84da-64ee8a548298

📥 Commits

Reviewing files that changed from the base of the PR and between a31fc7b and 0c8de45.

📒 Files selected for processing (1)
  • core/data_manager/strategy/cloud_strategy_impl.py

📝 Walkthrough

Walkthrough

The cloud strategy replaces the TEST dataset type with RL for stored landing records and training-data queries, including completed-step retrieval and maximum-step pagination.

Changes

Cloud dataset type alignment

Layer / File(s) Summary
Apply RL dataset type to cloud records and queries
core/data_manager/strategy/cloud_strategy_impl.py
Defines CLOUD_DATASET_TYPE as RL and applies it to LandingRecord creation, completed-step reads, and maximum-step queries.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: binhuangpjlab

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the main change: correcting the trajectory dataset type used in cloud strategy code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@two-tiger two-tiger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsballoon
hsballoon merged commit 7181fb8 into AI45Lab:v2 Jul 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants