Show what a Dev Drive name looks like, and say it is not the file name - #108
Merged
Conversation
…e name The name question already explained what the name is for, and was still answered with the .vhdx file name typed three questions earlier. It now carries a worked example, and quotes the default so it does not run into the sentence. The line saying the name is not the file name appears only in virtual disk mode: in the other two modes no .vhdx exists in the run, so naming one would invent it. The mode comes from the script body, which is the only thing that knows it. Closes #106 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by free · Input: 77.4K · Output: 10.6K · Cached: 236K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106
The name question already said what the name is for, and was still answered with the
.vhdxfile name typed three questions earlier — by the reporter of #3, in the run attached to #72. Explaining harder was not the answer; showing what a name looks like is.What a run now shows
Virtual disk mode:
Free-space and shrink modes get the first and third lines only.
Three changes
.vhdxexists in the run, so naming one would invent it.Request-DevDriveLabeltakes-VhdxMode, and the script body passes it — the body is the only thing that knows the mode. This is the shapeRequest-BitLockerChoiceandResolve-BitLockerSetupPlanalready use.Checks
Parse clean,
Invoke-ScriptAnalyzer -Recursereports nothing, 784 Pester tests pass (779 before).Five new tests and one updated assertion. Each was checked against a deliberate breakage of the line it covers — dropping the argument at the call site, dropping the worked example, unquoting the default, making the vhdx-only line unconditional — and every breakage was caught.
README.mdis unchanged: it describes this step as "Name: what the volume is called, or Enter forDevDrive", which stays true.Not done here
#107 replaces this question's shape entirely — one name, asked once, used for both the file and the volume. When that lands, the middle line added here goes with it.