Skip to content

Show what a Dev Drive name looks like, and say it is not the file name - #108

Merged
ALERTua merged 1 commit into
mainfrom
bugfix/106
Aug 27, 2026
Merged

Show what a Dev Drive name looks like, and say it is not the file name#108
ALERTua merged 1 commit into
mainfrom
bugfix/106

Conversation

@ALERTua

@ALERTua ALERTua commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Closes #106

The name question already said what the name is for, and was still answered with the .vhdx file name typed three questions earlier — by the reporter of #3, in the run attached to #72. Explaining harder was not the answer; showing what a name looks like is.

What a run now shows

Virtual disk mode:

The Dev Drive carries a name, which is what File Explorer shows beside its letter, like "Projects (D:)".
This is not the file name; the ".vhdx" keeps the name you gave it.
Enter a name for the Dev Drive, or press Enter for "DevDrive"

Free-space and shrink modes get the first and third lines only.

Three changes

  • A worked example instead of a description. The old line described the name; this one shows one.
  • The middle line only where a file was named. In the other two modes no .vhdx exists in the run, so naming one would invent it. Request-DevDriveLabel takes -VhdxMode, and the script body passes it — the body is the only thing that knows the mode. This is the shape Request-BitLockerChoice and Resolve-BitLockerSetupPlan already use.
  • The default is quoted, so it no longer runs into the sentence it ends.

Checks

Parse clean, Invoke-ScriptAnalyzer -Recurse reports nothing, 784 Pester tests pass (779 before).

Five new tests and one updated assertion. Each was checked against a deliberate breakage of the line it covers — dropping the argument at the call site, dropping the worked example, unquoting the default, making the vhdx-only line unconditional — and every breakage was caught.

README.md is unchanged: it describes this step as "Name: what the volume is called, or Enter for DevDrive", which stays true.

Not done here

#107 replaces this question's shape entirely — one name, asked once, used for both the file and the volume. When that lands, the middle line added here goes with it.

…e name

The name question already explained what the name is for, and was still answered
with the .vhdx file name typed three questions earlier. It now carries a worked
example, and quotes the default so it does not run into the sentence.

The line saying the name is not the file name appears only in virtual disk mode:
in the other two modes no .vhdx exists in the run, so naming one would invent it.
The mode comes from the script body, which is the only thing that knows it.

Closes #106

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@kilo-code-bot

kilo-code-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • dev_drive.ps1
  • dev_drive.Tests.ps1

Reviewed by free · Input: 77.4K · Output: 10.6K · Cached: 236K

@ALERTua
ALERTua merged commit 3e81481 into main Aug 27, 2026
3 checks passed
@ALERTua
ALERTua deleted the bugfix/106 branch August 27, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The name question is answered with the file name, because nothing says it is not one

1 participant