Show a path example where the path is typed - #110
Merged
Merged
Conversation
The example of a .vhdx path was printed once, three lines above the box it goes into, and had scrolled out of attention by the time the cursor was blinking. Eleven other prompts in this script already carry what they accept inside the prompt itself; this one now does too. Request-VhdxPath gains its first direct tests along with it: it had none, and only the rule that reads its answer was covered. Closes #109 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by free · Input: 90.6K · Output: 7.6K · Cached: 227.2K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
The example of a
.vhdxpath was printed once, three lines above the box it goes into:By the time the cursor is blinking it has scrolled out of attention, though it is still on screen. Now:
Eleven other prompts in this script already carry what they will accept inside the prompt itself —
Enter your choice (1 or 2),Enter $Subject in GB (min: $MinGB, $maxHint),Are you ready to proceed with Dev Drive creation? (yes/no),press Enter for "DevDrive". This brings the.vhdxpath in line with them.The line above keeps its own example deliberately.
Tests
Request-VhdxPathhad no direct tests: onlyResolve-VhdxPathInput, the rule that reads its answer, was covered. It now has two, and with them the first coverage of the question itself — that a path whose folder exists on a fixed drive is accepted and handed back, and that the prompt carries the example.Three deliberate breakages were checked against them: dropping the parenthetical, changing it to a different example path, and returning the parent folder instead of the path. Each was caught.
Checks
Parse clean,
Invoke-ScriptAnalyzer -Recursereports nothing, 786 Pester tests pass (784 before).