Conversation
xmlunit-legacy 2.13.0 declares junit:junit 3.8.1 as a compile dependency, for its JUnit 3 based classes (XMLTestCase, XMLAssert, Validator.assertIsValid). Since maven-surefire-plugin 3.6.0 (ShapeChange#789), surefire adds the JUnit Vintage engine to the test run whenever junit:junit is a test dependency; 3.5.6 did not, because the project declares junit-jupiter-engine. The Vintage engine rejects any junit:junit older than 4.12: TestEngine with ID 'junit-vintage' failed to discover tests Caused by: JUnitException: Unsupported version of junit:junit: 3.8.1. Please upgrade to version 4.12 or later. The forked test JVM of shapechange-app therefore fails before a single test executes, and `mvn test` reports "Tests run: 0" and a build failure there. shapechange-core has no junit:junit and is not affected. The tests use only xmlunit-legacy classes that do not depend on JUnit (Diff, HTMLDocumentBuilder, TolerantSaxDocumentBuilder, XMLUnit and jaxp13.Validator), and no test source uses JUnit 3 or 4. junit:junit is therefore excluded from the xmlunit-legacy dependency, in dependencyManagement so that it applies to every module that uses it. Signed-off-by: jdsika <carlo.van-driesten@vdl.digital>
jdsika
force-pushed
the
build/exclude-junit3-from-test-classpath
branch
from
September 26, 2026 11:26
2482b17 to
9a457dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of upstream ShapeChange#799.