Uds 2197: update or remove pkg to support react 19 - #1710
Merged
Conversation
remove reactstrap - package is no longer updated and does not support react19 - BreadcrumbItem converted to native LI element update react-share - update prop quote to title - add aria-label - update email share to proper usage (drafts share email, rather than using mailto:authorEmail link) - add console warning if required article prop is undefined, but still allows render
remove reactstrap - package is no longer updated and does not support react19
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1710/index.html |
mlsamuelson
previously approved these changes
Jun 1, 2026
mlsamuelson
left a comment
Member
There was a problem hiding this comment.
Approving. Thanks for this cleanup!
Only thing I noticed is that the focus on the share icons has a rounded corner. As Article isn't used anywhere, not going to flag it as blocking. Marking approved.
davidornelas11
requested changes
Jun 5, 2026
davidornelas11
left a comment
Contributor
There was a problem hiding this comment.
Some small changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove reactstrap
update react-share
(drafts share email, rather than using mailto:authorEmail link)
Checklist
Important Reminders
Links