Skip to content

fix(component-header-footer): adjust layout add dropdown examples #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlsamuelson merged 6 commits into from
Jul 1, 2026
Merged

fix(component-header-footer): adjust layout add dropdown examples #1721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
07b980c
fix(component-header-footer): adjust layout add dropdown examples
scott-williams-az Jun 16, 2026
ffd1bef
fix(component-header-footer): col divider bg fix
scott-williams-az Jun 18, 2026
4dbe1ac
fix(component-header-footer): col divider bg fix
scott-williams-az Jun 19, 2026
85b69be
fix(component-header-footer): col divider bg fix
scott-williams-az Jun 19, 2026
cbc8216
fix(component-header-footer): col divider bg fix
scott-williams-az Jun 19, 2026
82957af
chore: minor pr changes
scott-williams-az Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...nent-header-footer/src/header/components/HeaderMain/NavbarContainer/DropdownItem/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,20 @@ const DropdownItem = ({
);
};

let heightOffset = headerHeight;
if (buttons.length > 0) {
const ctaButtonRowHeight = 64;
heightOffset += ctaButtonRowHeight;
}

Comment thread
mlsamuelson marked this conversation as resolved.
return (
<DropdownWrapper
ref={dropdownRef}
className={`${classes}${alignedRight ? " aligned-right" : ""}${
isMega ? " mega" : ""
}`}
breakpoint={breakpoint}
headerHeight={headerHeight}
heightOffset={heightOffset}
>
<div
style={{ "--cols": cols < 3 ? 4 : cols }}
Expand Down
7 changes: 2 additions & 5 deletions ...ader-footer/src/header/components/HeaderMain/NavbarContainer/DropdownItem/index.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,10 @@ const DropdownWrapper = styled.div`
/*
max-height is calculated from
100% view Height
minus header
minus offset
minus 2rem padding
minus 4rem cta buttons - future we could add a ref to measure if needed
*/
max-height: calc(
100vh - ${({ headerHeight }) => headerHeight}px - 2rem - 4rem
);
max-height: calc(100vh - ${({ heightOffset }) => heightOffset}px - 2rem);
overflow-y: auto;
overflow-x: hidden;
display: flex;
Expand Down
6 changes: 3 additions & 3 deletions packages/component-header-footer/src/header/components/HeaderMain/NavbarContainer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ const NavbarContainer = () => {
return (
// @ts-ignore
<Wrapper breakpoint={breakpoint} data-testid="navigation" aria-label="Site">
{(navTree?.length || mobileNavTree?.length || buttons?.length) && (
{Boolean(navTree.length || mobileNavTree.length || buttons.length) && (
Comment thread
mlsamuelson marked this conversation as resolved.
<div className={CLASS_NAMES.CONTENT_CONTAINER}>
{(navTree?.length || mobileNavTree?.length) && (
{Boolean(navTree?.length || mobileNavTree?.length) && (
<ul className={CLASS_NAMES.NAV_LIST}>
{!!mobileNavTree?.length && isMobile
? mobileNavTree?.map((link, i) => renderItem(link, i))
: navTree?.map((link, i) => renderItem(link, i))}
</ul>
)}
{!!buttons?.length && (
{Boolean(buttons?.length) && (
<form
className={CLASS_NAMES.BUTTONS_CONTAINER}
data-testid="buttons-container"
Expand Down
2 changes: 1 addition & 1 deletion .../component-header-footer/src/header/components/HeaderMain/NavbarContainer/index.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const Wrapper = styled.nav`
overflow-y: auto;
min-height: 0;
> *:last-child {
margin-bottom: min(75px, 15vw);
margin-bottom: 1rem;
Comment thread
mlsamuelson marked this conversation as resolved.
}
}
.${CLASS_NAMES.NAV_LIST} {
Expand Down
2 changes: 1 addition & 1 deletion packages/component-header-footer/src/header/components/HeaderMain/index.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const HeaderMainWrapper = styled.div`
"search search search"
"nav nav nav";

height: calc(100dvh - ${({ headerTop }) => headerTop}px);
max-height: calc(100dvh - ${({ headerTop }) => headerTop}px);
overflow: hidden;
Comment thread
mlsamuelson marked this conversation as resolved.
.${CLASS_NAMES.PARTNER_TITLE}, .navbar-brand {
grid-area: logo;
Expand Down
Loading