fix(app-webdir-ui): render profile card title as bold text instead of h4#1746
Open
juanmitriatti wants to merge 1 commit into
Open
fix(app-webdir-ui): render profile card title as bold text instead of h4#1746juanmitriatti wants to merge 1 commit into
juanmitriatti wants to merge 1 commit into
Conversation
The Web Directory profile card rendered the person's work title in an h4, causing a skipped heading level on consuming sites where the card name is not a heading (accessibility issue). - ProfileCard (app-webdir-ui) and PersonProfile (unity-react-core) now render the title as p.person-profession-title > strong - unity-bootstrap-theme styles the new class identically to the old h4 (1rem, 700 weight, 1.625rem line-height, 2-line clamp); h4 selectors kept for backward compatibility with published consumers - person-profile Storybook template updated to the new markup
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1746/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accessibility fix (JSM "Web Directory - hdatds"): the profile card rendered the person's title in an
<h4>, causing a skipped heading level on consuming sites. The title is now<p class="person-profession-title"><strong>…</strong></p>— no heading, same visual design.Changes
ProfileCardand unity-react-corePersonProfile:h4→p.person-profession-title > strong_person-profile.scss: new class styled identically to the oldh4(1rem, 700, 1.625rem line-height, 2-line clamp);h4selectors kept for backward compatibilityTesting
ProfileCardtests: title is not a heading, renders as bold text in a paragraphPersonProfiletests updated; all 210 unity-react-core tests pass