Skip to content

DO NOT MERGE — regression replay to prove the journey gate goes red (#2336 AC 3) - #2404

Closed
dolho wants to merge 2 commits into
devfrom
test/2336-regression-replay
Closed

DO NOT MERGE — regression replay to prove the journey gate goes red (#2336 AC 3)#2404
dolho wants to merge 2 commits into
devfrom
test/2336-regression-replay

Conversation

@dolho

@dolho dolho commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Throwaway. Reverts ecf1327f (the #2092 fix) on top of dev so the 2026-08-14 "stopped agents will not start" regression is live again, and carries #2335/#2336's tier + gate.

Expected: journey-smoke FAILS on test_a_stopped_agent_can_be_started_again. If it passes, the gate does not have teeth and #2403 is not ready to be a required check.

Closing and deleting once observed.

… cause (#2336 AC 3)

First attempt reverted ecf1327 as the issue literally says, and the gate went
GREEN — because ecf1327 (#2092) is the commit that CAUSED 'starting a stopped
agent 500s'; reverting it removes the bug. The fix is 35a24d0 (#2186). This
reverts THAT, so the 500 is live again.

THROWAWAY — exists only to watch journey-smoke go red.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dolho
dolho force-pushed the test/2336-regression-replay branch from 408b48a to 8c22377 Compare August 26, 2026 08:50
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dolho

dolho commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Verified — this is what it existed for.

journey-smoke went RED on test_a_stopped_agent_can_be_started_again:

AssertionError: starting stopped agent 'pytest-ephemeral-journey-e15347a9'
answered 500: {"detail":"Failed to start agent (ValueError — details in backend logs)"}
— this is the 2026-08-14 regression: five of six stopped agents answered 500 here
and it reached users

Two things this replay established that a green run never would have:

  1. The issue's replay instruction is imprecise. ecf1327f (bug: recreate_container_with_updated_config unconditionally starts the container — running-state precondition is caller-enforced and undocumented #2092) is the commit that CAUSED the regression; reverting it removes the bug. The fix to revert is 35a24d0c (bug: starting a stopped agent 500s when a recreate is needed — require_running guard not satisfied by start_agent_internal #2186). My first attempt reverted ecf1327f as written and the gate passed — correctly, because the code was fine.
  2. The first version of the journey had no teeth. bug: starting a stopped agent 500s when a recreate is needed — require_running guard not satisfied by start_agent_internal #2186's title says the condition exactly: the 500 happened when a recreate is needed. A fresh agent stopped and started immediately has no config drift, so the bug is unreachable. The journey now changes resource limits while stopped to force the recreate path. Without that step it passed against the broken code — measured, not assumed.

Closing; branch deleted. Real work is #2403.

@dolho dolho closed this Aug 26, 2026
@dolho
dolho deleted the test/2336-regression-replay branch August 26, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant