examples standalone in repo - #106
Merged
Merged
Conversation
…la 2.12/spark3 support
dk1844
marked this pull request as ready for review
August 2, 2021 09:12
dk1844
force-pushed
the
feature/99-examples-standalone-in-repo
branch
from
August 2, 2021 10:39
2abd5f3 to
72ef1c3
Compare
dk1844
force-pushed
the
feature/99-examples-standalone-in-repo
branch
from
August 2, 2021 11:34
4e1f7f2 to
a5ad850
Compare
…) called at the end instead.
dk1844
requested review from
AB006J9,
TerezaHrubesova,
Zejnilovic and
benedeki
and removed request for
AB006J9
August 5, 2021 09:10
Zejnilovic
reviewed
Aug 9, 2021
Zejnilovic
left a comment
Collaborator
There was a problem hiding this comment.
I like it. i found only small things, more questions
| <plugin> | ||
| <groupId>com.github.wajda</groupId> | ||
| <artifactId>scala-cross-build-maven-plugin</artifactId> | ||
| <version>0.2.1</version> |
Collaborator
There was a problem hiding this comment.
I know this is in another pom as well. But could this be moved up to properties (even in the other one)
Collaborator
Author
There was a problem hiding this comment.
Thanks for noticing, fixed. While doing this, I have also moved the version of maven-release-plugin to properties.
| import scala.reflect.ClassTag | ||
| import scala.reflect.runtime.universe | ||
|
|
||
| trait SparkJobRunnerMethods { |
Collaborator
There was a problem hiding this comment.
I see this is in both examples and s3-examples. 1to1 copy. Is that needed?
Collaborator
Author
There was a problem hiding this comment.
Yes, it is 1:1 copy. Well, both projects need it to run tests and they are not depending on each other. What alternative do you have in mind?
README.md suggested change taken Co-authored-by: Saša Zejnilović <zejnils@gmail.com>
…release.plugin.version, scala.cross.build.maven.plugin.version) - licence check update (exclusions), workflow
Zejnilovic
previously approved these changes
Aug 12, 2021
AB006J9
previously approved these changes
Aug 13, 2021
Zejnilovic
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples have been moved to
examples/subfolder (core examples & s3 sdk extension examples). Each has their own maven pom definition and a readme.