#1769 Rename Menas to rest-api

[AdrianOlosutean]

Brace yourselves, the first part of renaming
Closes #1769

[AdrianOlosutean]

I'm not sure how exactly to handle the separation + renaming in README. Any proposals?

[dk1844]

I see nothing suspicious -> LGTM (just read the code)

[dk1844]

Very cool 😎

[Zejnilovic]

While I agree, I would do this

Suggested change

	____ _____ ____ _____ _ ____ ___
	| _ \| ____/ ___|_ _| / \ | _ \_ _|
	| |_) | _| \___ \ | |_____ / _ \ | |_) | |
	| _ <| |___ ___) || |_____/ ___ \| __/| |
	|_| \_\_____|____/ |_| /_/ \_\_| |___|
	version ${application.version}
	____ _____ ____ _____ _ ____ ___
	| _ \| ____/ ___|_ _| / \ | _ \_ _|
	| |_) | _| \___ \ | |_____ / _ \ | |_) | |
	| _ <| |___ ___) || |_____/ ___ \| __/| |
	|_| \_\_____|____/ |_| /_/ \_\_| |___|
	Enceladus version ${application.version}

[dk1844]

I'm not sure how exactly to handle the separation + renaming in README. Any proposals?

What do you have in mind specifically?
I would do about the following:

• in README,
  • in the ### Menas section, I'd update that it is only UI front-end and a general-purpose service API exists behind it.
  • in the ## How to run / #### Menas requirements section, I'd state that it's menas-web.war now and reword that some requirements are tied to the service REST API instead of to Menas directly.
  • (not aware of any other adjustments needed there, but anything is possible)

Then, consider what else must change in the GHP description, what actually public API endpoints to describe (if the time is right?) and publish (in a sense of making them public) them that way. But GHP changes are another story (i.e. PR) anyway.

[AdrianOlosutean]

I could not name this package object in tests to rest_api. Hopefully it's not too confusing, given that the module is rest-api and the package is rest_api

[dk1844]

I consider this acceptable.

[dk1844]

LGTM (just read the code)

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
86 Code Smells

No Coverage information
4.2% Duplication