1770 Rename menas web to menas - #1786
Merged
AdrianOlosutean merged 4 commits intoMay 26, 2021
Merged
Conversation
AdrianOlosutean
requested review from
DzMakatun,
HuvarVer,
benedeki,
dk1844 and
lokm01
as code owners
May 14, 2021 12:20
dk1844
previously approved these changes
May 18, 2021
dk1844
left a comment
Contributor
There was a problem hiding this comment.
LGTM (just read the code)
AdrianOlosutean
force-pushed
the
feature/1770-rename-menas-web-to-menas
branch
from
May 18, 2021 14:39
c4ba831 to
97d1194
Compare
AdrianOlosutean
force-pushed
the
feature/1770-rename-menas-web-to-menas
branch
from
May 18, 2021 15:07
97d1194 to
d370a40
Compare
benedeki
reviewed
May 18, 2021
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: danielchabr/pr-labels-checker@master | ||
| - uses: danielchabr/pr-labels-checker@v3.0 |
Contributor
Author
There was a problem hiding this comment.
@Zejnilovic suggested it, because the master is against some standards
Collaborator
There was a problem hiding this comment.
Are we sure it works? Because I had tried it with this entry when implementing the action and for an unknown reason, it was saying my the action plugin cannot be found/downloaded.
| "name": "menas", | ||
| "version": "3.0.0-SNAPSHOT", | ||
| "description": "Menas Client", | ||
| "description": "Menas UI Client", |
Collaborator
|
Haven't found any more menas-web mentioned anywhere in the code 👍 |
Collaborator
|
Question to discuss: do we rename some of the classed using Menas name? |
|
Kudos, SonarCloud Quality Gate passed!
|
benedeki
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1770