Skip to content

Bugfix/85 wrong type used in chapters definition#122

Merged
miroslavpojer merged 9 commits into
masterfrom
bugfix/85-Wrong-type-used-in-chapters-definition
Dec 12, 2024
Merged

Bugfix/85 wrong type used in chapters definition#122
miroslavpojer merged 9 commits into
masterfrom
bugfix/85-Wrong-type-used-in-chapters-definition

Conversation

@miroslavpojer

Copy link
Copy Markdown
Collaborator

Release Notes:

  • Change the format of input from JSON string to YAML array.
  • New dependency on PyYAML package.
  • Several minor improvements required by Pylint.

Closes #85

- Implemented yaml array type as input ofr chapters.
- Change format of input from json string to yaml array.
- Several small improvement required by pylint.

@tmikula-dev tmikula-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react and make correction to this PR.

Comment thread .github/workflows/release_draft.yml
Comment thread README.md
Comment thread README.md
Comment thread README.md Outdated
Comment thread action.yml Outdated
Comment thread examples/release_draft.yml
Comment thread release_notes_generator/action_inputs.py
Comment thread tests/release_notes/model/test_custom_chapters.py
…nition

# Conflicts:
#	.github/workflows/release_draft.yml
#	examples/release_draft.yml
#	release_notes_generator/action_inputs.py
#	release_notes_generator/utils/pull_reuqest_utils.py
#	requirements.txt
#	tests/test_action_inputs.py

@tmikula-dev tmikula-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to my review comments.

Comment thread release_notes_generator/action_inputs.py Outdated
Comment thread README.md
@tmikula-dev
tmikula-dev self-requested a review December 12, 2024 10:59
Comment thread action.yml Outdated
Comment thread release_notes_generator/action_inputs.py
@tmikula-dev
tmikula-dev self-requested a review December 12, 2024 11:16
@miroslavpojer
miroslavpojer merged commit d1b2cdb into master Dec 12, 2024
@miroslavpojer
miroslavpojer deleted the bugfix/85-Wrong-type-used-in-chapters-definition branch December 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong type used in chapters definition

2 participants