forked from lance-format/lance-graph
-
Notifications
You must be signed in to change notification settings - Fork 0
docs(board): post-merge hygiene for #920, and correct #917's falsified helix claims #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1084,3 +1084,57 @@ workspace** (root `Cargo.toml` `exclude`) and named in **no CI workflow** | |
| `[G-absence]` — so these 3 tests, and the crate's existing 77, run **only when | ||
| invoked by hand** in that crate. Adding them raises the floor for the next | ||
| session that looks; it does not put them on a gate. | ||
|
|
||
| #### 12.13 — the WIND reuse is the process, not an invention — and it surfaces a fit problem the normal-encode case never had | ||
|
|
||
| **Operator correction (2026-08-11):** *"the reuse of the above for the wind was | ||
| always part of the process (what you call invention)."* Accepted, and the line | ||
| §12.12 drew was wrong in **both** directions: | ||
|
|
||
| | | | | ||
| |---|---| | ||
| | **Invention** (what the arc rightly punished) | Asserting structure the code already answers — the 48-bit budget, the 2×24 in/out reading, `Pair48`, a round-trip API `continuous_field.rs` explicitly disclaims. | | ||
| | **Reuse** (the process) | Applying the **shipped, proven** codec to a new domain. This is what a normalized substrate is *for* — *"you only pay the inbound tax once."* | | ||
|
|
||
| §12.12 filed `from_normal` under *invention* and declined to build it. That was | ||
| over-correction: generalizing "don't invent structure the code already | ||
| determines" into "don't implement the intended reuse." **A missing entry point | ||
| for a designed reuse is a plumbing gap, not a design refusal** — the doctrine | ||
| doc even names the algorithm and points at a worked reference pair (q2 | ||
| `scratch-fma/helixbake` + `cockpit/src/BodyHelix.tsx`). | ||
|
|
||
| **What the reuse then surfaced (the actually-new finding) `[G]`.** | ||
| `encode_signed` derives **all three** direction-bearing fields from `n` alone | ||
| (`residue.rs:182-204`): `rim` from `(place, n)`, `polar` from | ||
| `signed_lift(n, …)`, `azimuth` from `n·φ`. Two candidate bearing encodes exist, | ||
|
Comment on lines
+1106
to
+1109
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Use the actual
📍 Affects 2 files
🤖 Prompt for AI Agents |
||
| and **the doctrine's prescribed one does not fit weather** — measured, N=65536 | ||
| (`crates/helix/tests/bearing_encode_paths.rs`): | ||
|
|
||
| | horizontal bearing | Path A — nearest `(n, sign)` (the doc's prescription) | Path B — direct `(polar, azimuth)` write | | ||
| |---|---|---| | ||
| | 0° | 1.933° | **0.000°** | | ||
| | 90° | 2.706° | **0.000°** | | ||
| | 270° | 1.897° | **0.000°** | | ||
| | **mean, 24 (bearing × elevation) cases** | **0.972°** | **0.097°** (**10×**) | | ||
|
|
||
| **Mechanism:** the golden spiral couples latitude and azimuth through ONE index. | ||
| Reaching `y ≈ 0` (horizontal) needs `n ≈ N−1`, and those few `n` have their | ||
| azimuth *already fixed* at `n·φ` — **you cannot independently choose a bearing at | ||
| the horizon.** Compounding it, the lattice's latitude density is ∝ `sin(2·lat)` | ||
| (equal-area on the **disk**, not the sphere), i.e. **sparsest exactly at the | ||
| equator.** Surface normals — the case the doc was written for — spread over the | ||
| whole sphere and never hit this. Wind bearings cluster at the horizon and always | ||
| do. | ||
|
|
||
| Path B is near-exact there (`y = 0 → polar = 128` exactly; 16-bit azimuth = | ||
| 0.0055° over 360°) and is licensed by the doctrine's **own** split: the `rim` | ||
| keeps carrying `(place, n)` as the metric, `(polar, azimuth)` carry the bearing, | ||
| and *"direction is place-INDEPENDENT."* The cost, stated: `(polar, azimuth)` are | ||
| no longer functions of the same `n` as `rim` — which under that split is the | ||
| intent, not a violation. | ||
|
|
||
| **Consequence:** a wind bearing encode should be the **direct field write**, not | ||
| the doc's `from_normal`. The doc's prescription is correct for its own case | ||
| (normals) and should be labelled as such rather than read as universal. **`[S]` | ||
| until an operator decides the API shape** — this section records the measurement | ||
| and the tradeoff, and deliberately does not mint a public `from_bearing`. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep the merged
#917record immutable.Line 54 appends a correction inside the merged
#917entry. This violates the board ledger rule and creates an audit mismatch with.claude/board/LATEST_STATE.md, which keeps the historical#917text unchanged.Remove the appended correction from the
#917entry. Keep the correction in the prepended#920entry. Retain only the permitted Confidence or Status update in the historical entry.As per coding guidelines: “Board files are append-only except status/confidence lines.” The retrieved board-hygiene learning also requires merged entries to remain unchanged and new information to be prepended.
🤖 Prompt for AI Agents
Sources: Coding guidelines, Learnings