ogar_codebook: sync the ConceptDomain wire-mirror — Ontology, Blocks, and the C-band - #960
Conversation
…, and the C-band The contract's mirror of OGAR's ConceptDomain ended at Geo (0x0F) while OGAR carries Ontology (0x03, populated by the DisMech 0x0333 mints), Blocks (0x17), and the C-band JavaRuntime/Analytics/BinaryLifting (0xC0/0xC1/0xC4 -- the altitude ruling, OGAR #276+#277; 0xC0 is Panama FFM alone, Valhalla being a property of the C0 vocabulary rather than an addressable concept). Both sides' docs demand they update together; this is the catch-up, found by the lance-graph-java session and verified independently by the ruff/R2IL session at db488f5, with ownership of the sync explicitly handed here so the ruff arc's PR3 rebases trivially. The real finding is WHY the drift guard never fired: domains_agree + assert_codebook_parity only walk ids that carry concept rows, so a reserved-EMPTY domain added to one enum but not the other is invisible to a content walk. Proven live -- the first disable-run (dropping the new BinaryLifting pair from domains_agree) stayed GREEN. Repaired with reserved_empty_domains_agree_across_the_mirror: one id per new domain, the populated 0x0333, the deliberate 0xC2-0xC3 gap pinned like OGAR's own 0x10-0x16, the band edges, and the 0x0C/0xC0 digit-swap two-sided. Both disable-runs (bridge pair dropped; contract arm dropped) now go red on exactly that test; the contract's own domain_routes_on_high_byte independently catches the arm removal. Gates: lance-graph-contract 1162/1162 + doctests, clippy --all-targets clean; lance-graph-ogar (workspace-excluded, tested via manifest-path) 64/64 incl. assert_codebook_parity green -- content parity holds, this was domain-level drift only. The crate's 11 pre-existing clippy warnings are measured identical with this diff stashed and left untouched. Board: EPIPHANIES E-OGAR-CODEBOOK-MIRROR-DOMAIN-DRIFT-SYNCED-1 prepended in the same commit, per the board-hygiene rule.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_537d8316-da54-4c8d-9ccf-f60456ebd06d) |
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The contract's wire-mirror of OGAR's
ConceptDomainended atGeo(0x0F) while OGAR carriesOntology(0x03 — populated, the DisMech 0x0333 mints of OGAR #275),Blocks(0x17), and the C-bandJavaRuntime/Analytics/BinaryLifting(0xC0/0xC1/0xC4 — the altitude ruling, OGAR #276 + #277;0xC0is Panama FFM alone, Valhalla being an integrated property of the C0 vocabulary rather than an addressable concept). Both sides' doc comments demand they update together under the drift guard; this is the catch-up.Cross-session provenance: found by the lance-graph-java session, verified independently by the ruff/R2IL session at
db488f5, ownership handed here explicitly so the ruff arc's PR3 (the R2IL container-concept mints under0xC4, replacingPROVISIONAL_R2IL_VARNODE = 0x0000) rebases trivially on top.The real finding: why the drift guard never fired
lance-graph-ogar'sdomains_agree+assert_codebook_parityonly walk ids that carry concept rows — so a reserved-EMPTY domain added to one enum but not the other is invisible to a content walk, which is exactly the class of drift a domain mirror exists to catch. Proven live, not argued: the first disable-run (dropping the newBinaryLiftingpair fromdomains_agree) stayed green — the pairing was vacuously guarded.Repaired with
reserved_empty_domains_agree_across_the_mirror: one id per new/reserved domain, the populated0x0333, the deliberate0xC2–0xC3gap (pinned like OGAR pins its own0x10–0x16), the band edges (0xBF00/0xC500), and the0x0C↔0xC0digit-swap hazard two-sided.domains_agreeBinaryLiftingpairdomain drift at 0xc4000xC4armdomain_routes_on_high_byteScope
Domain-level sync only. Content parity re-run and green (
assert_codebook_parity, 64/64 in the bridge crate via--manifest-path) — the drift was domains, not codebook rows.lance-graph-contract1162/1162 + doctests, clippy--all-targetsclean. The bridge crate's 11 pre-existing clippy warnings are measured identical with this diff stashed and left untouched.Board:
EPIPHANIES.mdE-OGAR-CODEBOOK-MIRROR-DOMAIN-DRIFT-SYNCED-1prepended in the same commit.Generated by Claude Code