Skip to content

Feature/dashboard sidebar - #26

Merged
Alejandroq12 merged 5 commits into
devfrom
feature/dashboard-sidebar
Aug 5, 2026
Merged

Alejandroq12 merged 5 commits into
devfrom
feature/dashboard-sidebar

Conversation

@Alejandroq12

@Alejandroq12 Alejandroq12 commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added a My Task page and navigation route.
    • Introduced a branded sidebar with Dashboard and My Task links.
    • Added active-route highlighting and accessible navigation indicators.
    • Updated the application layout with a header, sidebar, and scrollable content area.
  • Documentation

    • Documented accessibility guidance for active navigation states.
  • Tests

    • Expanded routing and sidebar accessibility test coverage.
image

Sidebar implements the Figma spec: centered logomark, nav items with
  the active treatment (primary-4 gradient wash, label color, right-edge
  indicator that renders invisibly on inactive rows so layout never shifts).
  NavLink supplies aria-current; 'end' on every item prevents prefix-matching
  from lighting tabs on unknown deep paths. Icons are the exported Figma
  vectors inlined with currentColor so one asset serves all states. Focus
  ring is inset to survive the aside's rounded overflow clipping. Header
  (shell-owned) replaces the positional Searchbar/Topbar pair. w-screen
  dropped from the shell to avoid scrollbar-width horizontal overflow.
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c29ddd4-6a59-4292-86a7-8786c6885993

📥 Commits

Reviewing files that changed from the base of the PR and between 0e0f73a and 00e15df.

📒 Files selected for processing (2)
  • README.md
  • src/components/layout/Sidebar.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/layout/Sidebar.tsx

📝 Walkthrough

Walkthrough

The application shell now renders a sidebar and header. The router registers the /my-task route. Tests cover My Task rendering and sidebar active-link behavior.

Changes

Application shell and My Task route

Layer / File(s) Summary
Application shell composition
src/components/layout/Header.tsx, src/components/layout/Sidebar.tsx, src/components/layout/Layout.tsx, README.md
The layout renders Header and Sidebar components. Sidebar provides Dashboard and My Task links with active-route accessibility state. The README documents the related contrast and aria-current="page" behavior.
My Task routing and validation
src/features/tasks/MyTask.tsx, src/app/router.tsx, src/app/router.test.tsx
The router renders MyTask at /my-task. Tests verify route rendering, active-link transitions, and inactive links on unknown deep paths.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Sidebar
  participant Router
  participant MyTask
  User->>Sidebar: select My Task
  Sidebar->>Router: navigate to /my-task
  Router->>MyTask: render MyTask
  MyTask-->>User: display My Task heading
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: adding the dashboard sidebar and related navigation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/dashboard-sidebar

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Aug 5, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@Alejandroq12
Alejandroq12 merged commit 11d8e87 into dev Aug 5, 2026
3 checks passed
@Alejandroq12 Alejandroq12 linked an issue Aug 5, 2026 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 2: Dashboard - Sidebar

1 participant