group: add align option to control children alignment (#2834) - #5282
Open
dominikake wants to merge 1 commit into
Open
group: add align option to control children alignment (#2834)#5282dominikake wants to merge 1 commit into
align option to control children alignment (#2834)#5282dominikake wants to merge 1 commit into
Conversation
Adds an optional `align` property to the group module
("start" | "center" | "end", default "center"). Children are
aligned within the group's box accordingly, so a group placed in
`modules-left` can left-align its contents instead of centering them.
Resolves the request in Alexays#2834.
Co-Authored-By: opencode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
alignproperty to the group module to control how itschildren are aligned within the group's box.
start|center|endcenter(preserves current behavior)This lets a group placed in
modules-leftleft-align its contents instead ofcentering them, as requested in #2834.
Implementation
include/group.hpp: addGtk::Align align_(defaultALIGN_CENTER).src/group.cpp: readconfig_["align"]in the constructor (throws oninvalid value, matching the existing
orientationhandling), and applywidget.set_halign(align_)to each child inaddWidget().man/waybar.5.scd.in: document the new option.Notes
I could not build/test this locally (no build toolchain in my environment), so
this relies on CI. If maintainers would prefer
startas the default to fullyresolve #2834 out of the box, I'm happy to flip the default.
Co-Authored-By: opencode noreply@opencode.ai