Skip to content

replace shallowCopy with move for ORC - #13

Merged
Araq merged 1 commit into
Araq:masterfrom
ringabout:master
Jul 30, 2022
Merged

replace shallowCopy with move for ORC#13
Araq merged 1 commit into
Araq:masterfrom
ringabout:master

Conversation

@ringabout

Copy link
Copy Markdown
Contributor

ref nim-lang/Nim#19972

it breaks nitter

2022-07-28T11:13:13.5379017Z �[1m�[36mTest "nitter" in category "nimble-packages"�[0m
2022-07-28T11:13:13.5379569Z �[1m�[31mFailure: reBuildFailed�[0m
2022-07-28T11:13:13.5380024Z nim c src/nitter.nim
2022-07-28T11:13:13.5380986Z Hint: used config file '/home/runner/work/Nim/Nim/config/nim.cfg' [Conf]
2022-07-28T11:13:13.5381782Z Hint: used config file '/home/runner/work/Nim/Nim/config/config.nims' [Conf]
2022-07-28T11:13:13.5391781Z Hint: used config file '/home/runner/work/Nim/Nim/pkgstemp/nitter/config.nims' [Conf]
2022-07-28T11:13:13.5392922Z ...........................................................................................................................................................................................
2022-07-28T11:13:13.5393785Z /home/runner/.nimble/pkgs/packedjson-#d11d167/packedjson.nim(325, 5) Error: undeclared identifier: 'shallowCopy'
2022-07-28T11:13:13.5394379Z candidates (edit distance, scope distance); see '--spellSuggest': 
2022-07-28T11:13:13.5394888Z  (4, 6): 'shallow' [proc declared in /home/runner/work/Nim/Nim/lib/system.nim(2799, 6)]
2022-07-28T11:13:13.5395390Z  (4, 6): 'shallow' [proc declared in /home/runner/work/Nim/Nim/lib/system.nim(2809, 6)]

@Araq
Araq merged commit 9e6fbb6 into Araq:master Jul 30, 2022
zedeus pushed a commit to zedeus/nitter that referenced this pull request Aug 30, 2022
Hello. `shallowCopy` has been removed for ARC/ORC since it does a deep copy for strings/seqs, which breaks the semantics of `shallowCopy`. Araq/packedjson#13 is a fix for `packedjson` to support ARC/ORC. The PR bumps `packedjson` dependency to include [a fix](Araq/packedjson@9e6fbb6) for ARC/ORC.
jackyzy823 pushed a commit to jackyzy823/nitter that referenced this pull request Mar 5, 2023
Hello. `shallowCopy` has been removed for ARC/ORC since it does a deep copy for strings/seqs, which breaks the semantics of `shallowCopy`. Araq/packedjson#13 is a fix for `packedjson` to support ARC/ORC. The PR bumps `packedjson` dependency to include [a fix](Araq/packedjson@9e6fbb6) for ARC/ORC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants