Generate repeated mnemonic words

[9iks]

const auto passphrase = Ark::Crypto::Identities::Mnemonic::generate();
Generate repeated mnemonic words!!!!!

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[9iks]

Open the file -> cpp-crypto/src/lib/bip39/src/bip39.cpp
line 123:
random_bytes_engine rbe;
+rbe.seed(std::random_device()());
std::vector<uint8_t> data(entropy_bits / BYTE_BITS);
std::generate(begin(data), end(data), &rbe { return static_cast<uint8_t>(std::ref(rbe)()); });

[sleepdefic1t]

Thank you, @9iks .
Didn’t catch the notification for this.
What OS/platform are you running this on?

@ciband wrote this section, perhaps he could weigh in.

I’ll be taking a look as well.

[ciband]

This is an issue in the BIP39 library. I have seen it before but have not had a chance to properly investigate and fix.

@9iks If you have a potential fix, please open a PR in https://github.com/ciband/bip39 and we can check it out. If I am understanding your comment, it looks like you do.

Thank you.

[sleepdefic1t]

bip39 lib removed in #86
This issue can now be closed, @faustbrian .

Thank you, @9iks & @ciband

[sleepdefic1t]

@faustbrian @9iks
The PR for removal of the BIP39 lib/mnemonic generation use has been merged (#86).
Unless there are more questions, this issue can be closed.

This issue has been closed. If you wish to re-open it please provide additional information.