refactor: CodeClimate Improvements - #166
Merged
faustbrian merged 2 commits intoOct 18, 2019
Merged
Conversation
- hash.cpp - use memmove vs raw loop. - crypto_helpers.h. - add offset to join method. - serializer.cpp - use join w/offset vs raw loop. - use std::accumulate vs raw loops. - transaction.cpp - initialize local vars. - use memmove vs strncpy & strncat. - use "%" PRIu32 vs "%d" in sprintf call. - use object.length() vs strlen.
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
October 17, 2019 00:50
Contributor
Author
|
@faustbrian good to go 👍 |
faustbrian
approved these changes
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves several code issues flagged in CodeClimate and Codacy.
Specifically, this PR does the following:
hash.cppmemmovevs raw loop.crypto_helpers.hjoinw/offset test.jointest.serializer.cppjoinw/offset vs raw loop.std::accumulatevs raw loops.transaction.cpptoArray()call.memmovevsstrncpy&strncat."%" PRIu32vs"%d"in sprintf call.object.length()vsstrlen.Checklist