Skip to content

ci: call correct EXE for windows tests - #170

Merged
faustbrian merged 5 commits into
ArkEcosystemArchive:developfrom
ciband:fix/windows_ci
Oct 28, 2019
Merged

ci: call correct EXE for windows tests#170
faustbrian merged 5 commits into
ArkEcosystemArchive:developfrom
ciband:fix/windows_ci

Conversation

@ciband

@ciband ciband commented Oct 26, 2019

Copy link
Copy Markdown
Contributor

Corrected syntax in call to unit test exe

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Corrected syntax in call to unit test exe
@ghost

ghost commented Oct 26, 2019

Copy link
Copy Markdown

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Oct 26, 2019
@ciband

ciband commented Oct 26, 2019

Copy link
Copy Markdown
Contributor Author

Seems like CI is stalled out. Not sure how to restart it. Might need an admin to do it.

@sleepdefic1t

Copy link
Copy Markdown
Contributor

CodeClimate issue resolved in #171

Not sure why the test workflows weren't triggered.
Blip in the matrix 🤷‍♂

Check the changes I suggested, we'll see if an update gets picked up properly.
I tested on my fork and it seemed to work.
sleepdefic1t@3e30963

sleepdefic1t
sleepdefic1t previously approved these changes Oct 28, 2019

@sleepdefic1t sleepdefic1t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should do it 👍
Thank you, @ciband

@faustbrian
Let's merge #171 first, please.
See if we can't get the workflows to trigger properly here.

Comment thread .github/workflows/test.yml
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Oct 28, 2019
@ghost

ghost commented Oct 28, 2019

Copy link
Copy Markdown

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost

ghost commented Oct 28, 2019

Copy link
Copy Markdown

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Oct 28, 2019
@faustbrian faustbrian changed the title (WIP) Fix Windows CI - Unit Test ci: call correct EXE for windows tests Oct 28, 2019
@faustbrian
faustbrian merged commit abab250 into ArkEcosystemArchive:develop Oct 28, 2019
@ghost

ghost commented Oct 28, 2019

Copy link
Copy Markdown

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Oct 28, 2019
@ghost

ghost commented Oct 28, 2019

Copy link
Copy Markdown

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Status: Member Approved The pull request has been approved by a member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants